[incubator-gobblin] branch master updated: [GOBBLIN-1260] add some logs in GobblinHelixTask

[suvasude]

This is an automated email from the ASF dual-hosted git repository.

suvasude pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-gobblin.git


The following commit(s) were added to refs/heads/master by this push:
     new 4ebb37e  [GOBBLIN-1260] add some logs in GobblinHelixTask
4ebb37e is described below

commit 4ebb37ec8ed56d6f5add275672cc0b10c0f8e413
Author: Arjun <ab...@linkedin.com>
AuthorDate: Tue Sep 15 08:45:24 2020 -0700

    [GOBBLIN-1260] add some logs in GobblinHelixTask
    
    Closes #3100 from arjun4084346/logHelixTaskCancel
---
 .../java/org/apache/gobblin/cluster/GobblinHelixTask.java    | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git 
a/gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixTask.java
 
b/gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixTask.java
index 6202f3e..48bd152 100644
--- 
a/gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixTask.java
+++ 
b/gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixTask.java
@@ -213,9 +213,17 @@ public class GobblinHelixTask implements Task {
 
   @Override
   public void cancel() {
-    log.info("Gobblin helix task cancellation invoked.");
+    log.info("Gobblin helix task cancellation invoked for jobId {}.", jobId);
     if (this.task != null ) {
-      this.task.cancel();
+      try {
+        this.task.cancel();
+        log.info("Gobblin helix task cancellation completed for jobId {}.", 
jobId);
+      } catch (Throwable t) {
+        log.info("Gobblin helix task cancellation for jobId {} failed with 
exception.", jobId, t);
+        Throwables.propagate(t);
+      }
+    } else {
+      log.warn("Cancel called for an uninitialized Gobblin helix task for 
jobId {}.", jobId);
     }
   }
 }