[incubator-gobblin] branch master updated: [GOBBLIN-1329] Supressing Stacktrace in HelixResult to avoid ZK disk usage overloading

[lesun]

This is an automated email from the ASF dual-hosted git repository.

lesun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-gobblin.git


The following commit(s) were added to refs/heads/master by this push:
     new 8e07f03  [GOBBLIN-1329] Supressing Stacktrace in HelixResult to avoid 
ZK disk usage overloading
8e07f03 is described below

commit 8e07f03dbd5adf3ef57ab012d05dace37beb30a1
Author: Lei Sun <autumn...@gmail.com>
AuthorDate: Wed Dec 2 12:02:27 2020 -0800

    [GOBBLIN-1329] Supressing Stacktrace in HelixResult to avoid ZK disk usage 
overloading
    
    Supressing Stacktrace in HelixResult to avoid ZK
    disk usage overloading
    
    Resolve reviewer's comments
    
    Closes #3164 from autumnust/helixLogSupress
---
 .../main/java/org/apache/gobblin/cluster/GobblinHelixTask.java    | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git 
a/gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixTask.java
 
b/gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixTask.java
index f2e236b..11a6095 100644
--- 
a/gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixTask.java
+++ 
b/gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixTask.java
@@ -31,6 +31,8 @@ import org.apache.gobblin.util.Id;
 import org.apache.gobblin.util.event.ContainerHealthCheckFailureEvent;
 import org.apache.gobblin.util.eventbus.EventBusFactory;
 import org.apache.gobblin.util.retry.RetryerFactory;
+
+import org.apache.commons.lang.exception.ExceptionUtils;
 import org.apache.hadoop.fs.FileSystem;
 import org.apache.hadoop.fs.Path;
 import org.apache.helix.task.JobContext;
@@ -179,11 +181,11 @@ public class GobblinHelixTask implements Task {
       log.error("Actual task {} failed in creation due to {}, will request new 
container to schedule it",
           this.taskId, te.getMessage());
       this.taskMetrics.helixTaskTotalCancelled.incrementAndGet();
-      return new TaskResult(TaskResult.Status.FAILED, 
Throwables.getStackTraceAsString(te));
+      return new TaskResult(TaskResult.Status.FAILED, "Root cause:" + 
ExceptionUtils.getRootCauseMessage(te));
     } catch (Throwable t) {
-      log.error("Actual task {} failed due to {}", this.taskId, 
t.getMessage());
+      log.error(String.format("Actual task %s failed due to:", this.taskId), 
t);
       this.taskMetrics.helixTaskTotalCancelled.incrementAndGet();
-      return new TaskResult(TaskResult.Status.FAILED, 
Throwables.getStackTraceAsString(t));
+      return new TaskResult(TaskResult.Status.FAILED, "");
     } finally {
       this.taskMetrics.helixTaskTotalRunning.decrementAndGet();
       this.taskMetrics.updateTimeForTaskExecution(startTime);