[gobblin] branch master updated: [GOBBLIN-1427] Handle MountPointNotFoundException when determining files in target for File Distcp

[lesun]

This is an automated email from the ASF dual-hosted git repository.

lesun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/gobblin.git


The following commit(s) were added to refs/heads/master by this push:
     new 6b14adf  [GOBBLIN-1427] Handle MountPointNotFoundException when 
determining files in target for File Distcp
6b14adf is described below

commit 6b14adf4b0ce02b3f71b0c5163c5807b13f78247
Author: William Lo <lo.willia...@gmail.com>
AuthorDate: Fri Apr 23 09:41:52 2021 -0700

    [GOBBLIN-1427] Handle MountPointNotFoundException when determining files in 
target for File Distcp
    
    Handle scenario where target directory cannot
    determine target files to copy but does not return
    a file not found exception for viewfs support
    
    Add logging of exception caught
    
    Closes #3263 from Will-Lo/use-ioexception-file-
    distcp
---
 .../gobblin/data/management/copy/RecursiveCopyableDataset.java       | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git 
a/gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/RecursiveCopyableDataset.java
 
b/gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/RecursiveCopyableDataset.java
index f6aaac9..8454bb4 100644
--- 
a/gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/RecursiveCopyableDataset.java
+++ 
b/gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/RecursiveCopyableDataset.java
@@ -17,6 +17,7 @@
 
 package org.apache.gobblin.data.management.copy;
 
+import lombok.extern.slf4j.Slf4j;
 import org.apache.gobblin.commit.CommitStep;
 import org.apache.gobblin.data.management.copy.entities.PrePublishStep;
 import org.apache.gobblin.data.management.dataset.DatasetUtils;
@@ -47,6 +48,7 @@ import com.google.common.collect.Maps;
  * Implementation of {@link CopyableDataset} that creates a {@link 
CopyableFile} for every file that is a descendant if
  * the root directory.
  */
+@Slf4j
 public class RecursiveCopyableDataset implements CopyableDataset, 
FileSystemDataset {
 
   private static final String CONFIG_PREFIX = CopyConfiguration.COPY_PREFIX + 
".recursive";
@@ -179,7 +181,8 @@ public class RecursiveCopyableDataset implements 
CopyableDataset, FileSystemData
     try {
       return FileListUtils
           .listFilesToCopyAtPath(fs, path, fileFilter, 
applyFilterToDirectories, includeEmptyDirectories);
-    } catch (FileNotFoundException fnfe) {
+    } catch (IOException e) {
+      log.info(String.format("Could not find any files on target path due to 
%s. Returning an empty list of files.", e.getClass().getCanonicalName()));
       return Lists.newArrayList();
     }
   }