[gobblin] branch master updated: Fix bug in `JobSpecSerializer` of inadequately preventing access errors (within `MysqlJobCatalog`) (#3447)

[zihanli58]

This is an automated email from the ASF dual-hosted git repository.

zihanli58 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/gobblin.git


The following commit(s) were added to refs/heads/master by this push:
     new d541fa6  Fix bug in `JobSpecSerializer` of inadequately preventing 
access errors (within `MysqlJobCatalog`) (#3447)
d541fa6 is described below

commit d541fa6e291211a787acc5416c3296f022e30846
Author: Kip Kohn <ck...@linkedin.com>
AuthorDate: Tue Dec 21 16:10:56 2021 -0800

    Fix bug in `JobSpecSerializer` of inadequately preventing access errors 
(within `MysqlJobCatalog`) (#3447)
---
 .../java/org/apache/gobblin/runtime/spec_serde/JobSpecSerializer.java  | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git 
a/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/spec_serde/JobSpecSerializer.java
 
b/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/spec_serde/JobSpecSerializer.java
index 01b57c2..8db15d2 100644
--- 
a/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/spec_serde/JobSpecSerializer.java
+++ 
b/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/spec_serde/JobSpecSerializer.java
@@ -39,8 +39,9 @@ public class JobSpecSerializer implements 
JsonSerializer<JobSpec> {
     jobSpecJson.add(JOB_SPEC_URI_KEY, context.serialize(src.getUri()));
     jobSpecJson.add(JOB_SPEC_VERSION_KEY, context.serialize(src.getVersion()));
     jobSpecJson.add(JOB_SPEC_DESCRIPTION_KEY, 
context.serialize(src.getDescription()));
-    jobSpecJson.add(JOB_SPEC_TEMPLATE_URI_KEY, 
src.getTemplateURI().isPresent() ? 
context.serialize(src.getJobTemplate().get()): null);
+    jobSpecJson.add(JOB_SPEC_TEMPLATE_URI_KEY, 
src.getTemplateURI().isPresent() ? 
context.serialize(src.getTemplateURI().get()) : null);
     jobSpecJson.add(JOB_SPEC_CONFIG_AS_PROPERTIES_KEY, 
context.serialize(src.getConfigAsProperties()));
+    // NOTE: do not serialize `JobSpec.jobTemplate`, since `transient`
 
     return jobSpecJson;
   }