This is an automated email from the ASF dual-hosted git repository.

wlo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/gobblin.git


The following commit(s) were added to refs/heads/master by this push:
     new 4e7317cb1 do not close DestinationDatasetHandlerService prematurely 
(#3601)
4e7317cb1 is described below

commit 4e7317cb1c17181bc4f6ec2c46fae27eca8203d0
Author: Arjun Singh Bora <[email protected]>
AuthorDate: Tue Nov 15 14:16:01 2022 -0600

    do not close DestinationDatasetHandlerService prematurely (#3601)
---
 .../main/java/org/apache/gobblin/runtime/AbstractJobLauncher.java   | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git 
a/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/AbstractJobLauncher.java
 
b/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/AbstractJobLauncher.java
index d7efdf549..e7c038fdf 100644
--- 
a/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/AbstractJobLauncher.java
+++ 
b/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/AbstractJobLauncher.java
@@ -510,10 +510,8 @@ public abstract class AbstractJobLauncher implements 
JobLauncher {
 
         // Perform work needed before writing is done
         Boolean canCleanUp = 
this.canCleanStagingData(this.jobContext.getJobState());
-        try (DestinationDatasetHandlerService destinationDatasetHandlerService 
=
-            new DestinationDatasetHandlerService(jobState, canCleanUp, 
this.eventSubmitter)) {
-          workUnitStream = 
destinationDatasetHandlerService.executeHandlers(workUnitStream);
-        }
+        workUnitStream = closer.register(new 
DestinationDatasetHandlerService(jobState, canCleanUp, this.eventSubmitter))
+            .executeHandlers(workUnitStream);
 
         //Initialize writer and converter(s)
         closer.register(WriterInitializerFactory.newInstace(jobState, 
workUnitStream)).initialize();

Reply via email to