(gobblin) branch master updated: add option to add connectTimeout in couchbase writer (#3958)

[arjun4084346]

This is an automated email from the ASF dual-hosted git repository.

arjun4084346 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/gobblin.git


The following commit(s) were added to refs/heads/master by this push:
     new 3f942d167 add option to add connectTimeout in couchbase writer (#3958)
3f942d167 is described below

commit 3f942d167e433ca72402350082361f77eb65d863
Author: Arjun Singh Bora <ab...@linkedin.com>
AuthorDate: Fri May 31 12:22:01 2024 -0700

    add option to add connectTimeout in couchbase writer (#3958)
---
 .../apache/gobblin/couchbase/writer/CouchbaseEnvironmentFactory.java   | 2 ++
 .../gobblin/couchbase/writer/CouchbaseWriterConfigurationKeys.java     | 3 +++
 2 files changed, 5 insertions(+)

diff --git 
a/gobblin-modules/gobblin-couchbase/src/main/java/org/apache/gobblin/couchbase/writer/CouchbaseEnvironmentFactory.java
 
b/gobblin-modules/gobblin-couchbase/src/main/java/org/apache/gobblin/couchbase/writer/CouchbaseEnvironmentFactory.java
index e405a054e..977012391 100644
--- 
a/gobblin-modules/gobblin-couchbase/src/main/java/org/apache/gobblin/couchbase/writer/CouchbaseEnvironmentFactory.java
+++ 
b/gobblin-modules/gobblin-couchbase/src/main/java/org/apache/gobblin/couchbase/writer/CouchbaseEnvironmentFactory.java
@@ -46,6 +46,7 @@ public class CouchbaseEnvironmentFactory {
     String sslTruststorePassword = ConfigUtils.getString(config, 
CouchbaseWriterConfigurationKeys.SSL_TRUSTSTORE_PASSWORD, "");
     Boolean certAuthEnabled = ConfigUtils.getBoolean(config, 
CouchbaseWriterConfigurationKeys.CERT_AUTH_ENABLED, false);
     Boolean dnsSrvEnabled = ConfigUtils.getBoolean(config, 
CouchbaseWriterConfigurationKeys.DNS_SRV_ENABLED, false);
+    Long connectTimeout = ConfigUtils.getLong(config, 
CouchbaseWriterConfigurationKeys.CONNECT_TIMEOUT, 
CouchbaseWriterConfigurationKeys.CONNECT_TIMEOUT_DEFAULT);
     Integer socketConnectTimeout = ConfigUtils.getInt(config, 
CouchbaseWriterConfigurationKeys.SOCKET_CONNECT_TIMEOUT,
         DefaultCouchbaseEnvironment.SOCKET_CONNECT_TIMEOUT);
 
@@ -56,6 +57,7 @@ public class CouchbaseEnvironmentFactory {
         .sslTruststoreFile(sslTruststoreFile)
         .sslTruststorePassword(sslTruststorePassword)
         .certAuthEnabled(certAuthEnabled)
+        .connectTimeout(connectTimeout)
         .dnsSrvEnabled(dnsSrvEnabled)
         .socketConnectTimeout(socketConnectTimeout);
 
diff --git 
a/gobblin-modules/gobblin-couchbase/src/main/java/org/apache/gobblin/couchbase/writer/CouchbaseWriterConfigurationKeys.java
 
b/gobblin-modules/gobblin-couchbase/src/main/java/org/apache/gobblin/couchbase/writer/CouchbaseWriterConfigurationKeys.java
index 782033faf..11cf9d0aa 100644
--- 
a/gobblin-modules/gobblin-couchbase/src/main/java/org/apache/gobblin/couchbase/writer/CouchbaseWriterConfigurationKeys.java
+++ 
b/gobblin-modules/gobblin-couchbase/src/main/java/org/apache/gobblin/couchbase/writer/CouchbaseWriterConfigurationKeys.java
@@ -53,6 +53,9 @@ public class CouchbaseWriterConfigurationKeys {
 
   public static final String OPERATION_TIMEOUT_MILLIS = 
prefix("operationTimeoutMillis");
   public static final long OPERATION_TIMEOUT_DEFAULT = 10000; // 10 second 
default timeout
+  public static final String CONNECT_TIMEOUT = prefix("connectTimeout");
+  // using the default value same as 
DefaultCouchbaseEnvironment.CONNECT_TIMEOUT which is private in 
java-client-2.7.6
+  public static final long CONNECT_TIMEOUT_DEFAULT = 
TimeUnit.SECONDS.toMillis(5);
 
   public static final String RETRIES_ENABLED = prefix("retriesEnabled");
   public static final boolean RETRIES_ENABLED_DEFAULT = false;