(gobblin) branch master updated: [GOBBLIN-2085] Increase hard-coded `startToCloseTimeout` for `ExecuteGobblinWorkflow` activities; also `WorkFulfillmentWorker` exec concurrency (#3970)

[wlo]

This is an automated email from the ASF dual-hosted git repository.

wlo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/gobblin.git


The following commit(s) were added to refs/heads/master by this push:
     new 4df6a52d5 [GOBBLIN-2085] Increase hard-coded `startToCloseTimeout` for 
`ExecuteGobblinWorkflow` activities; also `WorkFulfillmentWorker` exec 
concurrency (#3970)
4df6a52d5 is described below

commit 4df6a52d520b4c8718a5df5c71dcef1248b1161e
Author: Kip Kohn <ck...@linkedin.com>
AuthorDate: Wed Jun 12 11:55:17 2024 -0700

    [GOBBLIN-2085] Increase hard-coded `startToCloseTimeout` for 
`ExecuteGobblinWorkflow` activities; also `WorkFulfillmentWorker` exec 
concurrency (#3970)
---
 .../org/apache/gobblin/temporal/ddm/worker/WorkFulfillmentWorker.java | 4 ++--
 .../gobblin/temporal/ddm/workflow/impl/CommitStepWorkflowImpl.java    | 2 +-
 .../temporal/ddm/workflow/impl/ExecuteGobblinWorkflowImpl.java        | 2 +-
 .../ddm/workflow/impl/NestingExecOfProcessWorkUnitWorkflowImpl.java   | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git 
a/gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/worker/WorkFulfillmentWorker.java
 
b/gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/worker/WorkFulfillmentWorker.java
index 5256b8b2b..d4b8b3a91 100644
--- 
a/gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/worker/WorkFulfillmentWorker.java
+++ 
b/gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/worker/WorkFulfillmentWorker.java
@@ -37,8 +37,8 @@ import 
org.apache.gobblin.temporal.workflows.metrics.SubmitGTEActivityImpl;
 
 /** Worker for the {@link ProcessWorkUnitsWorkflowImpl} super-workflow */
 public class WorkFulfillmentWorker extends AbstractTemporalWorker {
-    public static final long DEADLOCK_DETECTION_TIMEOUT_SECONDS = 120;
-    public static final int MAX_EXECUTION_CONCURRENCY = 3;
+    public static final long DEADLOCK_DETECTION_TIMEOUT_SECONDS = 120; // 
TODO: make configurable!
+    public static final int MAX_EXECUTION_CONCURRENCY = 5; // TODO: make 
configurable!
 
     public WorkFulfillmentWorker(Config config, WorkflowClient workflowClient) 
{
         super(config, workflowClient);
diff --git 
a/gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/workflow/impl/CommitStepWorkflowImpl.java
 
b/gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/workflow/impl/CommitStepWorkflowImpl.java
index 263ed7e42..d568ea4e5 100644
--- 
a/gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/workflow/impl/CommitStepWorkflowImpl.java
+++ 
b/gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/workflow/impl/CommitStepWorkflowImpl.java
@@ -50,7 +50,7 @@ public class CommitStepWorkflowImpl implements 
CommitStepWorkflow {
       .build();
 
   private static final ActivityOptions ACTIVITY_OPTS = 
ActivityOptions.newBuilder()
-      .setStartToCloseTimeout(Duration.ofSeconds(999))
+      .setStartToCloseTimeout(Duration.ofHours(3)) // TODO: make 
configurable... also add activity heartbeats
       .setRetryOptions(ACTIVITY_RETRY_OPTS)
       .build();
 
diff --git 
a/gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/workflow/impl/ExecuteGobblinWorkflowImpl.java
 
b/gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/workflow/impl/ExecuteGobblinWorkflowImpl.java
index 7760883e9..f2723bef9 100644
--- 
a/gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/workflow/impl/ExecuteGobblinWorkflowImpl.java
+++ 
b/gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/workflow/impl/ExecuteGobblinWorkflowImpl.java
@@ -55,7 +55,7 @@ import org.apache.gobblin.util.PropertiesUtils;
 public class ExecuteGobblinWorkflowImpl implements ExecuteGobblinWorkflow {
   public static final String PROCESS_WORKFLOW_ID_BASE = "ProcessWorkUnits";
 
-  public static final Duration genWUsStartToCloseTimeout = 
Duration.ofMinutes(90); // TODO: make configurable
+  public static final Duration genWUsStartToCloseTimeout = 
Duration.ofHours(2); // TODO: make configurable... also add activity heartbeats
 
   private static final RetryOptions GEN_WUS_ACTIVITY_RETRY_OPTS = 
RetryOptions.newBuilder()
       .setInitialInterval(Duration.ofSeconds(3))
diff --git 
a/gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/workflow/impl/NestingExecOfProcessWorkUnitWorkflowImpl.java
 
b/gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/workflow/impl/NestingExecOfProcessWorkUnitWorkflowImpl.java
index c9b330255..96591e654 100644
--- 
a/gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/workflow/impl/NestingExecOfProcessWorkUnitWorkflowImpl.java
+++ 
b/gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/workflow/impl/NestingExecOfProcessWorkUnitWorkflowImpl.java
@@ -31,7 +31,7 @@ import 
org.apache.gobblin.temporal.util.nesting.workflow.AbstractNestingExecWork
 
 /** {@link 
org.apache.gobblin.temporal.util.nesting.workflow.NestingExecWorkflow} for 
{@link ProcessWorkUnit} */
 public class NestingExecOfProcessWorkUnitWorkflowImpl extends 
AbstractNestingExecWorkflowImpl<WorkUnitClaimCheck, Integer> {
-  public static final Duration processWorkUnitStartToCloseTimeout = 
Duration.ofMinutes(20); // TODO: make configurable
+  public static final Duration processWorkUnitStartToCloseTimeout = 
Duration.ofHours(3); // TODO: make configurable... also add activity heartbeats
 
   // RetryOptions specify how to automatically handle retries when Activities 
fail.
   private static final RetryOptions ACTIVITY_RETRY_OPTS = 
RetryOptions.newBuilder()