(gobblin) branch master updated: Update Hive retention to add table location to retention dataset root property (#4006)

[wlo]

This is an automated email from the ASF dual-hosted git repository.

wlo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/gobblin.git


The following commit(s) were added to refs/heads/master by this push:
     new 6aa65309c7 Update Hive retention to add table location to retention 
dataset root property (#4006)
6aa65309c7 is described below

commit 6aa65309c7a93353719bc50f79a4d3d489134bf0
Author: William Lo <lo.willia...@gmail.com>
AuthorDate: Thu Jul 18 18:19:17 2024 -0400

    Update Hive retention to add table location to retention dataset root 
property (#4006)
---
 .../retention/dataset/finder/CleanableHiveDatasetFinder.java        | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git 
a/gobblin-data-management/src/main/java/org/apache/gobblin/data/management/retention/dataset/finder/CleanableHiveDatasetFinder.java
 
b/gobblin-data-management/src/main/java/org/apache/gobblin/data/management/retention/dataset/finder/CleanableHiveDatasetFinder.java
index 3b4a42e475..49679d52ef 100644
--- 
a/gobblin-data-management/src/main/java/org/apache/gobblin/data/management/retention/dataset/finder/CleanableHiveDatasetFinder.java
+++ 
b/gobblin-data-management/src/main/java/org/apache/gobblin/data/management/retention/dataset/finder/CleanableHiveDatasetFinder.java
@@ -28,6 +28,7 @@ import org.apache.gobblin.config.client.ConfigClient;
 import org.apache.gobblin.data.management.copy.hive.HiveDatasetFinder;
 import 
org.apache.gobblin.data.management.retention.dataset.CleanableHiveDataset;
 import 
org.apache.gobblin.data.management.retention.dataset.ConfigurableCleanableDataset;
+import org.apache.gobblin.data.management.retention.dataset.FsCleanableHelper;
 
 
 public class CleanableHiveDatasetFinder extends HiveDatasetFinder {
@@ -41,7 +42,10 @@ public class CleanableHiveDatasetFinder extends 
HiveDatasetFinder {
   }
 
   protected CleanableHiveDataset createHiveDataset(Table table, Config 
datasetConfig) throws IOException {
-    return new CleanableHiveDataset(super.fs, super.clientPool, new 
org.apache.hadoop.hive.ql.metadata.Table(table), super.properties, 
datasetConfig);
+    Properties datasetProperties = new Properties();
+    datasetProperties.putAll(this.properties);
+    datasetProperties.put(FsCleanableHelper.RETENTION_DATASET_ROOT, 
table.getSd().getLocation());
+    return new CleanableHiveDataset(super.fs, super.clientPool, new 
org.apache.hadoop.hive.ql.metadata.Table(table), datasetProperties, 
datasetConfig);
   }
 
   private static Properties setConfigPrefix(Properties props) {