(gobblin) branch master updated: DagProcessingThread bug fix (#4109)

[abhijain]

This is an automated email from the ASF dual-hosted git repository.

abhijain pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/gobblin.git


The following commit(s) were added to refs/heads/master by this push:
     new 60a9d31720 DagProcessingThread bug fix (#4109)
60a9d31720 is described below

commit 60a9d31720bd9216f4a09a11880b84d3d82d9e1c
Author: vsinghal85 <vsingha...@gmail.com>
AuthorDate: Fri Apr 4 19:37:01 2025 +0530

    DagProcessingThread bug fix (#4109)
    
    * DagProcessingThread bug fix and enhance logging
    
    ---------
    
    Co-authored-by: Vaibhav Singhal
---
 .../gobblin/service/modules/orchestration/task/DagTask.java   | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git 
a/gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/task/DagTask.java
 
b/gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/task/DagTask.java
index 6a7f981183..0e48c1c4c6 100644
--- 
a/gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/task/DagTask.java
+++ 
b/gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/task/DagTask.java
@@ -65,10 +65,15 @@ public abstract class DagTask {
       boolean completedLease = this.leaseObtainedStatus.completeLease();
       
this.dagProcEngineMetrics.markDagActionsConclude(this.dagAction.getDagActionType(),
 completedLease);
       return completedLease;
-    } catch (IOException e) {
-      
this.dagProcEngineMetrics.markDagActionsConclude(this.dagAction.getDagActionType(),
 false);
+    } catch (Exception e) {
+      try {
+        
this.dagProcEngineMetrics.markDagActionsConclude(this.dagAction.getDagActionType(),
 false);
+      } catch(Exception ex){
+        log.error("Exception encountered in emitting metrics for dag node ID: 
{}, dag action type: {}. Stacktrace: ", dagAction.getDagNodeId(), 
dagAction.getDagActionType(), ex);
+      }
       // TODO: Decide appropriate exception to throw and add to the commit 
method's signature
-      throw new RuntimeException(e);
+      log.error("Exception encountered in processing this DagTask, for dag 
node ID: {}, dag action type: {}. Stacktrace: ", dagAction.getDagNodeId(), 
dagAction.getDagActionType(), e);
+      return false;
     }
   }
 }