This is an automated email from the ASF dual-hosted git repository.

vivekrai pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/gobblin.git


The following commit(s) were added to refs/heads/master by this push:
     new 05487669f2 change aggregation temporality to DELTA instead of 
CUMULATIVE (#4111)
05487669f2 is described below

commit 05487669f25d0323095cf4a555d3ef902eaf2870
Author: Vivek Rai <[email protected]>
AuthorDate: Mon Apr 21 10:00:33 2025 +0530

    change aggregation temporality to DELTA instead of CUMULATIVE (#4111)
---
 .../main/java/org/apache/gobblin/metrics/OpenTelemetryMetrics.java | 2 ++
 .../gobblin/temporal/workflows/metrics/TemporalMetricsHelper.java  | 7 +++++++
 2 files changed, 9 insertions(+)

diff --git 
a/gobblin-metrics-libs/gobblin-metrics/src/main/java/org/apache/gobblin/metrics/OpenTelemetryMetrics.java
 
b/gobblin-metrics-libs/gobblin-metrics/src/main/java/org/apache/gobblin/metrics/OpenTelemetryMetrics.java
index 349ae438d9..72241b5dcc 100644
--- 
a/gobblin-metrics-libs/gobblin-metrics/src/main/java/org/apache/gobblin/metrics/OpenTelemetryMetrics.java
+++ 
b/gobblin-metrics-libs/gobblin-metrics/src/main/java/org/apache/gobblin/metrics/OpenTelemetryMetrics.java
@@ -33,6 +33,7 @@ import 
io.opentelemetry.exporter.otlp.http.metrics.OtlpHttpMetricExporter;
 import 
io.opentelemetry.exporter.otlp.http.metrics.OtlpHttpMetricExporterBuilder;
 import io.opentelemetry.sdk.OpenTelemetrySdk;
 import io.opentelemetry.sdk.metrics.SdkMeterProvider;
+import io.opentelemetry.sdk.metrics.export.AggregationTemporalitySelector;
 import io.opentelemetry.sdk.metrics.export.MetricExporter;
 import io.opentelemetry.sdk.metrics.export.PeriodicMetricReader;
 import io.opentelemetry.sdk.resources.Resource;
@@ -86,6 +87,7 @@ public class OpenTelemetryMetrics extends 
OpenTelemetryMetricsBase {
         httpExporterBuilder.addHeader(header.getKey(), header.getValue());
       }
     }
+    
httpExporterBuilder.setAggregationTemporalitySelector(AggregationTemporalitySelector.deltaPreferred());
     return httpExporterBuilder.build();
   }
 
diff --git 
a/gobblin-temporal/src/main/java/org/apache/gobblin/temporal/workflows/metrics/TemporalMetricsHelper.java
 
b/gobblin-temporal/src/main/java/org/apache/gobblin/temporal/workflows/metrics/TemporalMetricsHelper.java
index 443c5613da..29730c1133 100644
--- 
a/gobblin-temporal/src/main/java/org/apache/gobblin/temporal/workflows/metrics/TemporalMetricsHelper.java
+++ 
b/gobblin-temporal/src/main/java/org/apache/gobblin/temporal/workflows/metrics/TemporalMetricsHelper.java
@@ -33,6 +33,7 @@ import com.uber.m3.tally.StatsReporter;
 
 import io.micrometer.core.instrument.Clock;
 import io.micrometer.core.instrument.MeterRegistry;
+import io.micrometer.registry.otlp.AggregationTemporality;
 import io.micrometer.registry.otlp.OtlpConfig;
 import io.micrometer.registry.otlp.OtlpMeterRegistry;
 import io.temporal.common.reporter.MicrometerClientStatsReporter;
@@ -91,6 +92,12 @@ public class TemporalMetricsHelper {
         return 
GobblinTemporalConfigurationKeys.TEMPORAL_METRICS_OTLP_PREFIX_WITHOUT_DOT;
       }
 
+      @NotNull
+      @Override
+      public AggregationTemporality aggregationTemporality() {
+        return AggregationTemporality.DELTA;
+      }
+
       @NotNull
       @Override
       public Map<String, String> headers() {

Reply via email to