Repository: incubator-gobblin Updated Branches: refs/heads/master 9a05b70da -> 381857173
[GOBBLIN-336] move single task runner option constants to the option class This will improve class coherency. This will improve class coherency. Also removed an unused constant. Closes #2208 from HappyRay/move-constants-in- runner-option Project: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/commit/38185717 Tree: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/tree/38185717 Diff: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/diff/38185717 Branch: refs/heads/master Commit: 381857173564a1e28bce5374f2ac7c2f90543f88 Parents: 9a05b70 Author: Ray Yang <[email protected]> Authored: Fri Dec 15 09:10:58 2017 -0800 Committer: Abhishek Tiwari <[email protected]> Committed: Fri Dec 15 09:10:58 2017 -0800 ---------------------------------------------------------------------- .../gobblin/cluster/GobblinClusterConfigurationKeys.java | 8 -------- .../apache/gobblin/cluster/SingleTaskRunnerMainOptions.java | 7 +++---- 2 files changed, 3 insertions(+), 12 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-gobblin/blob/38185717/gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinClusterConfigurationKeys.java ---------------------------------------------------------------------- diff --git a/gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinClusterConfigurationKeys.java b/gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinClusterConfigurationKeys.java index 46a7311..3d9759c 100644 --- a/gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinClusterConfigurationKeys.java +++ b/gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinClusterConfigurationKeys.java @@ -79,12 +79,4 @@ public class GobblinClusterConfigurationKeys { public static final String STOP_TIMEOUT_SECONDS = GOBBLIN_CLUSTER_PREFIX + "stopTimeoutSeconds"; public static final long DEFAULT_STOP_TIMEOUT_SECONDS = 60; - - // Arguments to the single task runner process - public static class SingleTaskRunnerCmdOption { - public static final String JOB_ID = "job_id"; - public static final String WORK_UNIT_FILE_PATH = "work_unit_file_path"; - public static final String JOB_STATE_FILE_PATH = "job_state_file_path"; - public static final String CLUSTER_CONFIG_FILE_PATH = "cluster_config_file_path"; - } } http://git-wip-us.apache.org/repos/asf/incubator-gobblin/blob/38185717/gobblin-cluster/src/main/java/org/apache/gobblin/cluster/SingleTaskRunnerMainOptions.java ---------------------------------------------------------------------- diff --git a/gobblin-cluster/src/main/java/org/apache/gobblin/cluster/SingleTaskRunnerMainOptions.java b/gobblin-cluster/src/main/java/org/apache/gobblin/cluster/SingleTaskRunnerMainOptions.java index 60ac61f..ca988fe 100644 --- a/gobblin-cluster/src/main/java/org/apache/gobblin/cluster/SingleTaskRunnerMainOptions.java +++ b/gobblin-cluster/src/main/java/org/apache/gobblin/cluster/SingleTaskRunnerMainOptions.java @@ -31,13 +31,12 @@ import org.slf4j.LoggerFactory; import com.google.common.collect.ImmutableMap; -import static org.apache.gobblin.cluster.GobblinClusterConfigurationKeys.SingleTaskRunnerCmdOption.CLUSTER_CONFIG_FILE_PATH; -import static org.apache.gobblin.cluster.GobblinClusterConfigurationKeys.SingleTaskRunnerCmdOption.JOB_ID; -import static org.apache.gobblin.cluster.GobblinClusterConfigurationKeys.SingleTaskRunnerCmdOption.WORK_UNIT_FILE_PATH; - class SingleTaskRunnerMainOptions { private static final Logger logger = LoggerFactory.getLogger(SingleTaskRunnerMainOptions.class); + static final String CLUSTER_CONFIG_FILE_PATH = "cluster_config_file_path"; + static final String WORK_UNIT_FILE_PATH = "work_unit_file_path"; + static final String JOB_ID = "job_id"; private static final ImmutableMap<String, String> OPTIONS_MAP = ImmutableMap .of(JOB_ID, "job id", WORK_UNIT_FILE_PATH, "work unit file path", CLUSTER_CONFIG_FILE_PATH, "cluster configuration file path");
