Repository: incubator-gobblin Updated Branches: refs/heads/master 979ad2a09 -> 1ddaffa4d
[GOBBLIN-424] Ensure job context is closed even if job fails. Closes #2301 from ibuenros/broker-close-fix Project: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/commit/1ddaffa4 Tree: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/tree/1ddaffa4 Diff: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/diff/1ddaffa4 Branch: refs/heads/master Commit: 1ddaffa4d2b93ea27c407ea3c8e33cd874649a31 Parents: 979ad2a Author: ibuenros <issac.buenros...@gmail.com> Authored: Mon Mar 12 13:28:22 2018 -0700 Committer: Abhishek Tiwari <abhishektiwari.bt...@gmail.com> Committed: Mon Mar 12 13:28:22 2018 -0700 ---------------------------------------------------------------------- .../main/java/org/apache/gobblin/runtime/AbstractJobLauncher.java | 1 + .../src/main/java/org/apache/gobblin/runtime/JobContext.java | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-gobblin/blob/1ddaffa4/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/AbstractJobLauncher.java ---------------------------------------------------------------------- diff --git a/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/AbstractJobLauncher.java b/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/AbstractJobLauncher.java index 06782a9..da770af 100644 --- a/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/AbstractJobLauncher.java +++ b/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/AbstractJobLauncher.java @@ -340,6 +340,7 @@ public abstract class AbstractJobLauncher implements JobLauncher { TimingEvent launchJobTimer = this.eventSubmitter.getTimingEvent(TimingEvent.LauncherTimings.FULL_JOB_EXECUTION); try (Closer closer = Closer.create()) { + closer.register(this.jobContext); notifyListeners(this.jobContext, jobListener, TimingEvent.LauncherTimings.JOB_PREPARE, new JobListenerAction() { @Override public void apply(JobListener jobListener, JobContext jobContext) http://git-wip-us.apache.org/repos/asf/incubator-gobblin/blob/1ddaffa4/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/JobContext.java ---------------------------------------------------------------------- diff --git a/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/JobContext.java b/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/JobContext.java index 73d613c..d8fbe4e 100644 --- a/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/JobContext.java +++ b/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/JobContext.java @@ -481,7 +481,6 @@ public class JobContext implements Closeable { throw new IOException(exc); } this.jobState.setState(JobState.RunningState.COMMITTED); - close(); } @Override
