[GOBBLIN-370] added some log information Closes #2245 from arjun4084346/enhanceLogging
Project: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/commit/7d11c650 Tree: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/tree/7d11c650 Diff: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/diff/7d11c650 Branch: refs/heads/0.12.0 Commit: 7d11c65015acb4b52b4ae5dcf6f0f888ad097a2a Parents: 6cbc0cd Author: Arjun <[email protected]> Authored: Mon Feb 5 11:56:20 2018 -0800 Committer: Abhishek Tiwari <[email protected]> Committed: Mon Feb 5 11:56:20 2018 -0800 ---------------------------------------------------------------------- .../java/org/apache/gobblin/metrics/reporter/EventReporter.java | 4 ++-- .../java/org/apache/gobblin/runtime/AbstractJobLauncher.java | 1 + .../main/java/org/apache/gobblin/runtime/SafeDatasetCommit.java | 3 +++ 3 files changed, 6 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-gobblin/blob/7d11c650/gobblin-metrics-libs/gobblin-metrics-base/src/main/java/org/apache/gobblin/metrics/reporter/EventReporter.java ---------------------------------------------------------------------- diff --git a/gobblin-metrics-libs/gobblin-metrics-base/src/main/java/org/apache/gobblin/metrics/reporter/EventReporter.java b/gobblin-metrics-libs/gobblin-metrics-base/src/main/java/org/apache/gobblin/metrics/reporter/EventReporter.java index a733d6a..70e581c 100644 --- a/gobblin-metrics-libs/gobblin-metrics-base/src/main/java/org/apache/gobblin/metrics/reporter/EventReporter.java +++ b/gobblin-metrics-libs/gobblin-metrics-base/src/main/java/org/apache/gobblin/metrics/reporter/EventReporter.java @@ -129,8 +129,8 @@ public abstract class EventReporter extends ScheduledReporter implements Closeab event, this.getClass().getCanonicalName()); } } catch (InterruptedException ie) { - log.warn(String.format("Enqueuing of event %s at reporter with class %s was interrupted.", event, - this.getClass().getCanonicalName()), ie); + log.warn("Enqueuing of event {} at reporter with class {} was interrupted.", event, + this.getClass().getCanonicalName(), ie); } } http://git-wip-us.apache.org/repos/asf/incubator-gobblin/blob/7d11c650/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/AbstractJobLauncher.java ---------------------------------------------------------------------- diff --git a/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/AbstractJobLauncher.java b/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/AbstractJobLauncher.java index d59e097..06782a9 100644 --- a/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/AbstractJobLauncher.java +++ b/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/AbstractJobLauncher.java @@ -483,6 +483,7 @@ public abstract class AbstractJobLauncher implements JobLauncher { // Set the overall job state to FAILED if the job failed to process any dataset if (datasetState.getState() == JobState.RunningState.FAILED) { jobState.setState(JobState.RunningState.FAILED); + LOG.warn("At least one dataset state is FAILED. Setting job state to FAILED."); break; } } http://git-wip-us.apache.org/repos/asf/incubator-gobblin/blob/7d11c650/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/SafeDatasetCommit.java ---------------------------------------------------------------------- diff --git a/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/SafeDatasetCommit.java b/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/SafeDatasetCommit.java index 7e2e9fa..a80d832 100644 --- a/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/SafeDatasetCommit.java +++ b/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/SafeDatasetCommit.java @@ -399,6 +399,9 @@ final class SafeDatasetCommit implements Callable<Void> { // 2. Otherwise, the processing of the dataset is considered successful even if some tasks for the // dataset failed to be committed. datasetState.setState(JobState.RunningState.FAILED); + Optional<String> taskStateException = taskState.getTaskFailureException(); + log.warn("At least one task did not committed successfully. Setting dataset state to FAILED.", + taskStateException.isPresent() ? taskStateException.get() : "Exception not set."); } } }
