Repository: incubator-gobblin Updated Branches: refs/heads/master 5b8f7dfb1 -> 10dcf688a
[GOBBLIN-436] Add default constructor for SalesforceSource Closes #2314 from yukuai518/s2 Project: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/commit/10dcf688 Tree: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/tree/10dcf688 Diff: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/diff/10dcf688 Branch: refs/heads/master Commit: 10dcf688aac5fbbfbd37afb13b607a9d776f30d2 Parents: 5b8f7df Author: Kuai Yu <[email protected]> Authored: Thu Mar 22 18:23:07 2018 -0700 Committer: Hung Tran <[email protected]> Committed: Thu Mar 22 18:23:07 2018 -0700 ---------------------------------------------------------------------- .../java/org/apache/gobblin/salesforce/SalesforceSource.java | 4 ++++ .../java/org/apache/gobblin/salesforce/SalesforceSourceTest.java | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-gobblin/blob/10dcf688/gobblin-salesforce/src/main/java/org/apache/gobblin/salesforce/SalesforceSource.java ---------------------------------------------------------------------- diff --git a/gobblin-salesforce/src/main/java/org/apache/gobblin/salesforce/SalesforceSource.java b/gobblin-salesforce/src/main/java/org/apache/gobblin/salesforce/SalesforceSource.java index b16a261..3702c2e 100644 --- a/gobblin-salesforce/src/main/java/org/apache/gobblin/salesforce/SalesforceSource.java +++ b/gobblin-salesforce/src/main/java/org/apache/gobblin/salesforce/SalesforceSource.java @@ -110,6 +110,10 @@ public class SalesforceSource extends QueryBasedSource<JsonArray, JsonElement> { private static final Gson GSON = new Gson(); private boolean isEarlyStopped = false; + public SalesforceSource() { + this.lineageInfo = Optional.absent(); + } + @VisibleForTesting SalesforceSource(LineageInfo lineageInfo) { this.lineageInfo = Optional.fromNullable(lineageInfo); http://git-wip-us.apache.org/repos/asf/incubator-gobblin/blob/10dcf688/gobblin-salesforce/src/test/java/org/apache/gobblin/salesforce/SalesforceSourceTest.java ---------------------------------------------------------------------- diff --git a/gobblin-salesforce/src/test/java/org/apache/gobblin/salesforce/SalesforceSourceTest.java b/gobblin-salesforce/src/test/java/org/apache/gobblin/salesforce/SalesforceSourceTest.java index a03476b..5e9fbba 100644 --- a/gobblin-salesforce/src/test/java/org/apache/gobblin/salesforce/SalesforceSourceTest.java +++ b/gobblin-salesforce/src/test/java/org/apache/gobblin/salesforce/SalesforceSourceTest.java @@ -58,7 +58,7 @@ public class SalesforceSourceTest { void testGenerateSpecifiedPartitionFromSinglePointHistogram() { SalesforceSource.Histogram histogram = new SalesforceSource.Histogram(); histogram.add(new SalesforceSource.HistogramGroup("2014-02-13-00:00:00", 10)); - SalesforceSource source = new SalesforceSource(null); + SalesforceSource source = new SalesforceSource(); long expectedHighWatermark = 20170407152123L; long lowWatermark = 20140213000000L; @@ -75,7 +75,7 @@ public class SalesforceSourceTest { String[] groupInfo = group.split("::"); histogram.add(new SalesforceSource.HistogramGroup(groupInfo[0], Integer.parseInt(groupInfo[1]))); } - SalesforceSource source = new SalesforceSource(null); + SalesforceSource source = new SalesforceSource(); long expectedHighWatermark = 20170407152123L; long lowWatermark = 20140213000000L;
