Repository: incubator-gobblin
Updated Branches:
  refs/heads/master 55bf7a42b -> 7c2833a12


[GOBBLIN-486] Change access modifiers for SalesforceWriter to protected to help 
extend on top of it

Closes #2356 from abti/master


Project: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/commit/7c2833a1
Tree: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/tree/7c2833a1
Diff: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/diff/7c2833a1

Branch: refs/heads/master
Commit: 7c2833a12103c355f28eff909cd400491a23ab6c
Parents: 55bf7a4
Author: Abhishek Tiwari <[email protected]>
Authored: Fri May 4 05:38:02 2018 -0700
Committer: Abhishek Tiwari <[email protected]>
Committed: Fri May 4 05:38:02 2018 -0700

----------------------------------------------------------------------
 .../writer/http/SalesforceRestWriter.java       | 26 +++++++++++---------
 1 file changed, 14 insertions(+), 12 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-gobblin/blob/7c2833a1/gobblin-core/src/main/java/org/apache/gobblin/writer/http/SalesforceRestWriter.java
----------------------------------------------------------------------
diff --git 
a/gobblin-core/src/main/java/org/apache/gobblin/writer/http/SalesforceRestWriter.java
 
b/gobblin-core/src/main/java/org/apache/gobblin/writer/http/SalesforceRestWriter.java
index 5e001d3..813c495 100644
--- 
a/gobblin-core/src/main/java/org/apache/gobblin/writer/http/SalesforceRestWriter.java
+++ 
b/gobblin-core/src/main/java/org/apache/gobblin/writer/http/SalesforceRestWriter.java
@@ -20,6 +20,7 @@ import java.io.IOException;
 import java.net.URI;
 import java.net.URISyntaxException;
 
+import lombok.Getter;
 import org.apache.commons.lang3.StringUtils;
 import org.apache.commons.lang3.builder.ToStringBuilder;
 import org.apache.commons.lang3.builder.ToStringStyle;
@@ -53,6 +54,7 @@ import com.google.gson.JsonParser;
  * Writes to Salesforce via RESTful API, supporting INSERT_ONLY_NOT_EXIST, and 
UPSERT.
  *
  */
+@Getter
 public class SalesforceRestWriter extends RestJsonWriter {
   public static enum Operation {
     INSERT_ONLY_NOT_EXIST,
@@ -60,20 +62,20 @@ public class SalesforceRestWriter extends RestJsonWriter {
   }
   static final String DUPLICATE_VALUE_ERR_CODE = "DUPLICATE_VALUE";
 
-  private String accessToken;
+  protected String accessToken;
 
-  private final URI oauthEndPoint;
-  private final String clientId;
-  private final String clientSecret;
-  private final String userId;
-  private final String password;
-  private final String securityToken;
-  private final Operation operation;
+  protected final URI oauthEndPoint;
+  protected final String clientId;
+  protected final String clientSecret;
+  protected final String userId;
+  protected final String password;
+  protected final String securityToken;
+  protected final Operation operation;
 
-  private final int batchSize;
-  private final Optional<String> batchResourcePath;
-  private Optional<JsonArray> batchRecords = Optional.absent();
-  private long numRecordsWritten = 0L;
+  protected final int batchSize;
+  protected final Optional<String> batchResourcePath;
+  protected Optional<JsonArray> batchRecords = Optional.absent();
+  protected long numRecordsWritten = 0L;
 
   public SalesforceRestWriter(SalesForceRestWriterBuilder builder) {
     super(builder);

Reply via email to