Repository: incubator-gobblin Updated Branches: refs/heads/master d5fbabffc -> 9d3c731ad
[GOBBLIN-494] Add configs to disable retry Closes #2365 from yukuai518/retry Project: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/commit/9d3c731a Tree: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/tree/9d3c731a Diff: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/diff/9d3c731a Branch: refs/heads/master Commit: 9d3c731ade237e2b18dffac65192d8941a48ce05 Parents: d5fbabf Author: Kuai Yu <[email protected]> Authored: Wed Jun 20 15:14:55 2018 -0700 Committer: Hung Tran <[email protected]> Committed: Wed Jun 20 15:14:55 2018 -0700 ---------------------------------------------------------------------- .../java/org/apache/gobblin/writer/DataWriterWrapperBuilder.java | 4 +++- .../src/main/java/org/apache/gobblin/writer/RetryWriter.java | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-gobblin/blob/9d3c731a/gobblin-core/src/main/java/org/apache/gobblin/writer/DataWriterWrapperBuilder.java ---------------------------------------------------------------------- diff --git a/gobblin-core/src/main/java/org/apache/gobblin/writer/DataWriterWrapperBuilder.java b/gobblin-core/src/main/java/org/apache/gobblin/writer/DataWriterWrapperBuilder.java index bcf3c73..44141be 100644 --- a/gobblin-core/src/main/java/org/apache/gobblin/writer/DataWriterWrapperBuilder.java +++ b/gobblin-core/src/main/java/org/apache/gobblin/writer/DataWriterWrapperBuilder.java @@ -51,7 +51,9 @@ public class DataWriterWrapperBuilder<D> extends DataWriterBuilder<Void, D> { && state.contains(ThrottleWriter.WRITER_THROTTLE_TYPE_KEY)) { wrapped = new ThrottleWriter<>(wrapped, state); } - wrapped = new RetryWriter<>(wrapped, state); + if (state.getPropAsBoolean(RetryWriter.RETRY_WRITER_ENABLED, true)) { + wrapped = new RetryWriter<>(wrapped, state); + } return wrapped; } } http://git-wip-us.apache.org/repos/asf/incubator-gobblin/blob/9d3c731a/gobblin-core/src/main/java/org/apache/gobblin/writer/RetryWriter.java ---------------------------------------------------------------------- diff --git a/gobblin-core/src/main/java/org/apache/gobblin/writer/RetryWriter.java b/gobblin-core/src/main/java/org/apache/gobblin/writer/RetryWriter.java index f19c30c..5fe838c 100644 --- a/gobblin-core/src/main/java/org/apache/gobblin/writer/RetryWriter.java +++ b/gobblin-core/src/main/java/org/apache/gobblin/writer/RetryWriter.java @@ -51,6 +51,7 @@ import org.apache.gobblin.util.FinalState; public class RetryWriter<D> extends WatermarkAwareWriterWrapper<D> implements DataWriter<D>, FinalState, SpeculativeAttemptAwareConstruct { private static final Logger LOG = LoggerFactory.getLogger(RetryWriter.class); public static final String RETRY_CONF_PREFIX = "gobblin.writer.retry."; + public static final String RETRY_WRITER_ENABLED = RETRY_CONF_PREFIX + "enabled"; public static final String FAILED_RETRY_WRITES_METER = RETRY_CONF_PREFIX + "failed_writes"; public static final String RETRY_MULTIPLIER = RETRY_CONF_PREFIX + "multiplier"; public static final String RETRY_MAX_WAIT_MS_PER_INTERVAL = RETRY_CONF_PREFIX + "max_wait_ms_per_interval";
