Repository: incubator-gobblin Updated Branches: refs/heads/master 709b0af99 -> 2631c5ae6
[GOBBLIN-639] Change method to static for RequesterService serder Closes #2509 from kyuamazon/requester2 Project: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/commit/2631c5ae Tree: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/tree/2631c5ae Diff: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/diff/2631c5ae Branch: refs/heads/master Commit: 2631c5ae644df4a49689356be8774ae584230b18 Parents: 709b0af Author: Kuai Yu <[email protected]> Authored: Tue Nov 27 14:10:29 2018 -0800 Committer: Hung Tran <[email protected]> Committed: Tue Nov 27 14:10:29 2018 -0800 ---------------------------------------------------------------------- .../gobblin/service/RequesterService.java | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-gobblin/blob/2631c5ae/gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/RequesterService.java ---------------------------------------------------------------------- diff --git a/gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/RequesterService.java b/gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/RequesterService.java index 1fac68a..5dcd0d7 100644 --- a/gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/RequesterService.java +++ b/gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/RequesterService.java @@ -48,23 +48,23 @@ public abstract class RequesterService { * {@link Config}, we first use Base64 to encode the json string, * then use URL encoding to remove characters like '+,/,='. */ - public String serialize(List<ServiceRequester> requestersList) throws IOException { - String arrayToJson = objectMapper.writeValueAsString(requestersList); - String encodedString = Base64.getEncoder().encodeToString(arrayToJson.getBytes("UTF-8")); - return URLEncoder.encode(encodedString, "UTF-8"); + public static String serialize(List<ServiceRequester> requesterList) throws IOException { + String jsonList = objectMapper.writeValueAsString(requesterList); + String base64Str = Base64.getEncoder().encodeToString(jsonList.getBytes("UTF-8")); + return URLEncoder.encode(base64Str, "UTF-8"); } /** * <p> This implementation decode a given string encoded by * {@link #serialize(List)}. */ - public List<ServiceRequester> deserialize(String encodedString) throws IOException { - String urlDecoded = URLDecoder.decode(encodedString, "UTF-8"); - byte[] decodedBytes = Base64.getDecoder().decode(urlDecoded); - String serialized = new String(decodedBytes, "UTF-8"); + public static List<ServiceRequester> deserialize(String encodedString) throws IOException { + String base64Str = URLDecoder.decode(encodedString, "UTF-8"); + byte[] decodedBytes = Base64.getDecoder().decode(base64Str); + String jsonList = new String(decodedBytes, "UTF-8"); TypeReference<List<ServiceRequester>> mapType = new TypeReference<List<ServiceRequester>>() {}; - List<ServiceRequester> jsonToPersonList = objectMapper.readValue(serialized, mapType); - return jsonToPersonList; + List<ServiceRequester> requesterList = objectMapper.readValue(jsonList, mapType); + return requesterList; } protected abstract List<ServiceRequester> findRequesters(BaseResource resource);
