This is an automated email from the ASF dual-hosted git repository.
hutran pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-gobblin.git
The following commit(s) were added to refs/heads/master by this push:
new 67014ed [GOBBLIN-688] Make FsJobStatusRetriever config more scoped.[]
67014ed is described below
commit 67014ed7104e09667bfc54bc10ca99f0ea30616c
Author: suvasude <[email protected]>
AuthorDate: Wed Feb 20 14:29:31 2019 -0800
[GOBBLIN-688] Make FsJobStatusRetriever config more scoped.[]
Closes #2560 from sv2000/fsJobStatusRetriever
---
.../org/apache/gobblin/service/monitoring/FsJobStatusRetriever.java | 5 ++++-
.../apache/gobblin/service/monitoring/FsJobStatusRetrieverTest.java | 3 ++-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git
a/gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/FsJobStatusRetriever.java
b/gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/FsJobStatusRetriever.java
index 46ba73b..b5f8828 100644
---
a/gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/FsJobStatusRetriever.java
+++
b/gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/FsJobStatusRetriever.java
@@ -47,11 +47,14 @@ import org.apache.gobblin.metrics.event.TimingEvent;
*/
@Slf4j
public class FsJobStatusRetriever extends JobStatusRetriever {
+ public static final String CONF_PREFIX = "fsJobStatusRetriever";
+
@Getter
private final FileContextBasedFsStateStore<State> stateStore;
public FsJobStatusRetriever(Config config) {
- this.stateStore = (FileContextBasedFsStateStore<State>) new
FileContextBasedFsStateStoreFactory().createStateStore(config, State.class);
+ this.stateStore = (FileContextBasedFsStateStore<State>) new
FileContextBasedFsStateStoreFactory().
+ createStateStore(config.getConfig(CONF_PREFIX), State.class);
}
@Override
diff --git
a/gobblin-service/src/test/java/org/apache/gobblin/service/monitoring/FsJobStatusRetrieverTest.java
b/gobblin-service/src/test/java/org/apache/gobblin/service/monitoring/FsJobStatusRetrieverTest.java
index be42982..694dc5f 100644
---
a/gobblin-service/src/test/java/org/apache/gobblin/service/monitoring/FsJobStatusRetrieverTest.java
+++
b/gobblin-service/src/test/java/org/apache/gobblin/service/monitoring/FsJobStatusRetrieverTest.java
@@ -55,7 +55,8 @@ public class FsJobStatusRetrieverTest {
@BeforeClass
public void setUp() throws Exception {
cleanUpDir(stateStoreDir);
- Config config =
ConfigFactory.empty().withValue(ConfigurationKeys.STATE_STORE_ROOT_DIR_KEY,
ConfigValueFactory.fromAnyRef(stateStoreDir));
+ Config config =
ConfigFactory.empty().withValue(FsJobStatusRetriever.CONF_PREFIX + "." +
ConfigurationKeys.STATE_STORE_ROOT_DIR_KEY,
+ ConfigValueFactory.fromAnyRef(stateStoreDir));
this.jobStatusRetriever = new FsJobStatusRetriever(config);
this.fsStateStore = this.jobStatusRetriever.getStateStore();
}