[incubator-gobblin] branch master updated: [GOBBLIN-892][GOBBLIN-864] reverting back bad changes done in PR 2720

[suvasude]

This is an automated email from the ASF dual-hosted git repository.

suvasude pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-gobblin.git


The following commit(s) were added to refs/heads/master by this push:
     new 32805d9  [GOBBLIN-892][GOBBLIN-864] reverting back bad changes done in 
PR 2720
32805d9 is described below

commit 32805d9105d9d506743aa37b7c39119d6cd5ffe2
Author: Arjun <ab...@linkedin.com>
AuthorDate: Wed Oct 2 13:13:20 2019 -0700

    [GOBBLIN-892][GOBBLIN-864] reverting back bad changes done in PR 2720
    
    Closes #2747 from arjun4084346/fix
---
 .../java/org/apache/gobblin/runtime/SafeDatasetCommit.java   | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git 
a/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/SafeDatasetCommit.java
 
b/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/SafeDatasetCommit.java
index d9f63b1..5782196 100644
--- 
a/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/SafeDatasetCommit.java
+++ 
b/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/SafeDatasetCommit.java
@@ -327,10 +327,8 @@ final class SafeDatasetCommit implements Callable<Void> {
         datasetState.setState(JobState.RunningState.FAILED);
         datasetState.incrementJobFailures();
         Optional<String> taskStateException = 
taskState.getTaskFailureException();
-        String errMsg = "At least one task did not committed successfully. 
Setting dataset state to FAILED. "
-            + (taskStateException.isPresent() ? taskStateException.get() : 
"Exception not set.");
-        log.warn(errMsg);
-        datasetState.setJobFailureMessage(errMsg);
+        log.warn("At least one task did not committed successfully. Setting 
dataset state to FAILED. "
+            + (taskStateException.isPresent() ? taskStateException.get() : 
"Exception not set."));
         return;
       }
     }
@@ -406,10 +404,8 @@ final class SafeDatasetCommit implements Callable<Void> {
           //    dataset failed to be committed.
           datasetState.setState(JobState.RunningState.FAILED);
           Optional<String> taskStateException = 
taskState.getTaskFailureException();
-          String errMsg = "At least one task did not committed successfully. 
Setting dataset state to FAILED. "
-              + (taskStateException.isPresent() ? taskStateException.get() : 
"Exception not set.");
-          log.warn(errMsg);
-          datasetState.setJobFailureMessage(errMsg);
+          log.warn("At least one task did not committed successfully. Setting 
dataset state to FAILED. {}",
+              taskStateException.isPresent() ? taskStateException.get() : 
"Exception not set.");
         }
       }
     }