[incubator-gobblin] branch master updated: [GOBBLIN-904] Provide an option to reuse an existing Helix cluster on Gobblin-Yarn application launch[]

[suvasude]

This is an automated email from the ASF dual-hosted git repository.

suvasude pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-gobblin.git


The following commit(s) were added to refs/heads/master by this push:
     new 1446694  [GOBBLIN-904] Provide an option to reuse an existing Helix 
cluster on Gobblin-Yarn application launch[]
1446694 is described below

commit 144669493453621fbeb05c77e5d47f8e204b62df
Author: sv2000 <sudarsh...@gmail.com>
AuthorDate: Mon Oct 7 21:08:30 2019 -0700

    [GOBBLIN-904] Provide an option to reuse an existing Helix cluster on 
Gobblin-Yarn application launch[]
    
    Closes #2757 from sv2000/reuseHelixCluster
---
 .../org/apache/gobblin/cluster/GobblinClusterConfigurationKeys.java  | 4 ++++
 .../main/java/org/apache/gobblin/yarn/GobblinYarnAppLauncher.java    | 5 ++++-
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git 
a/gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinClusterConfigurationKeys.java
 
b/gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinClusterConfigurationKeys.java
index 4b21f4e..8ffb97c 100644
--- 
a/gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinClusterConfigurationKeys.java
+++ 
b/gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinClusterConfigurationKeys.java
@@ -169,4 +169,8 @@ public class GobblinClusterConfigurationKeys {
   public static final long DEFAULT_HELIX_JOB_STOPPING_STATE_TIMEOUT_SECONDS = 
300;
   public static final String CONTAINER_HEALTH_METRICS_SERVICE_ENABLED = 
GOBBLIN_CLUSTER_PREFIX + "container.health.metrics.service.enabled" ;
   public static final boolean DEFAULT_CONTAINER_HEALTH_METRICS_SERVICE_ENABLED 
= false;
+
+  //Config to enable/disable reuse of existing Helix Cluster
+  public static final String HELIX_CLUSTER_OVERWRITE_KEY = 
GOBBLIN_CLUSTER_PREFIX + "helix.overwrite";
+  public static final boolean DEFAULT_HELIX_CLUSTER_OVERWRITE = true;
 }
diff --git 
a/gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinYarnAppLauncher.java
 
b/gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinYarnAppLauncher.java
index 827c597..8542f13 100644
--- 
a/gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinYarnAppLauncher.java
+++ 
b/gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinYarnAppLauncher.java
@@ -283,8 +283,11 @@ public class GobblinYarnAppLauncher {
     this.eventBus.register(this);
 
     String clusterName = 
this.config.getString(GobblinClusterConfigurationKeys.HELIX_CLUSTER_NAME_KEY);
+    boolean overwriteExistingCluster = ConfigUtils.getBoolean(this.config, 
GobblinClusterConfigurationKeys.HELIX_CLUSTER_OVERWRITE_KEY,
+        GobblinClusterConfigurationKeys.DEFAULT_HELIX_CLUSTER_OVERWRITE);
+    LOGGER.info("Creating Helix cluster {} with overwrite: {}", clusterName, 
overwriteExistingCluster);
     HelixUtils.createGobblinHelixCluster(
-        
this.config.getString(GobblinClusterConfigurationKeys.ZK_CONNECTION_STRING_KEY),
 clusterName);
+        
this.config.getString(GobblinClusterConfigurationKeys.ZK_CONNECTION_STRING_KEY),
 clusterName, overwriteExistingCluster);
     LOGGER.info("Created Helix cluster " + clusterName);
 
     connectHelixManager();