This is an automated email from the ASF dual-hosted git repository. suvasude pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-gobblin.git
The following commit(s) were added to refs/heads/master by this push: new d54e66b [GOBBLIN-1106] do not remove requester list d54e66b is described below commit d54e66b857a34e871fd7c9ab28e37c9c9f061432 Author: Arjun <ab...@linkedin.com> AuthorDate: Wed Apr 1 13:47:13 2020 -0700 [GOBBLIN-1106] do not remove requester list Closes #2946 from arjun4084346/requesterFix --- .../org/apache/gobblin/service/FlowConfigResourceLocalHandler.java | 3 --- .../org/apache/gobblin/service/FlowConfigV2ResourceLocalHandler.java | 5 ----- 2 files changed, 8 deletions(-) diff --git a/gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/FlowConfigResourceLocalHandler.java b/gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/FlowConfigResourceLocalHandler.java index 8a7ddd1..8357037 100644 --- a/gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/FlowConfigResourceLocalHandler.java +++ b/gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/FlowConfigResourceLocalHandler.java @@ -106,9 +106,6 @@ public class FlowConfigResourceLocalHandler implements FlowConfigsResourceHandle // remove keys that were injected as part of flowSpec creation flowProps.remove(ConfigurationKeys.JOB_SCHEDULE_KEY); flowProps.remove(ConfigurationKeys.JOB_TEMPLATE_PATH); - flowProps.remove(ConfigurationKeys.FLOW_GROUP_KEY); - flowProps.remove(ConfigurationKeys.FLOW_NAME_KEY); - flowProps.remove(RequesterService.REQUESTER_LIST); StringMap flowPropsAsStringMap = new StringMap(); flowPropsAsStringMap.putAll(Maps.fromProperties(flowProps)); diff --git a/gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/FlowConfigV2ResourceLocalHandler.java b/gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/FlowConfigV2ResourceLocalHandler.java index b86da5e..efdb990 100644 --- a/gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/FlowConfigV2ResourceLocalHandler.java +++ b/gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/FlowConfigV2ResourceLocalHandler.java @@ -84,11 +84,6 @@ public class FlowConfigV2ResourceLocalHandler extends FlowConfigResourceLocalHan httpStatus = HttpStatus.S_400_BAD_REQUEST; } - // Remove unnecessary properties - flowConfig.getProperties().remove(ConfigurationKeys.FLOW_GROUP_KEY); - flowConfig.getProperties().remove(ConfigurationKeys.FLOW_NAME_KEY); - flowConfig.getProperties().remove(RequesterService.REQUESTER_LIST); - return new CreateKVResponse(new ComplexResourceKey<>(flowConfig.getId(), flowStatusId), flowConfig, httpStatus); }