Repository: incubator-gossip Updated Branches: refs/heads/master c4cb0d7c6 -> 4e13c899f
GOSSIP-20 Updated Javadocs to reflect URI objects, removed hostname and port references Project: http://git-wip-us.apache.org/repos/asf/incubator-gossip/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-gossip/commit/4e13c899 Tree: http://git-wip-us.apache.org/repos/asf/incubator-gossip/tree/4e13c899 Diff: http://git-wip-us.apache.org/repos/asf/incubator-gossip/diff/4e13c899 Branch: refs/heads/master Commit: 4e13c899f09c6292cd390a01f4799746de237ad4 Parents: c4cb0d7 Author: Rishabh Patel <[email protected]> Authored: Tue Aug 2 14:11:23 2016 -0700 Committer: Rishabh Patel <[email protected]> Committed: Tue Aug 2 14:20:25 2016 -0700 ---------------------------------------------------------------------- src/main/java/org/apache/gossip/GossipMember.java | 14 ++++++-------- .../java/org/apache/gossip/RemoteGossipMember.java | 8 +++----- src/main/java/org/apache/gossip/StartupSettings.java | 8 ++++---- 3 files changed, 13 insertions(+), 17 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-gossip/blob/4e13c899/src/main/java/org/apache/gossip/GossipMember.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/gossip/GossipMember.java b/src/main/java/org/apache/gossip/GossipMember.java index dbc84b2..58b1e91 100644 --- a/src/main/java/org/apache/gossip/GossipMember.java +++ b/src/main/java/org/apache/gossip/GossipMember.java @@ -35,7 +35,7 @@ public abstract class GossipMember implements Comparable<GossipMember> { protected final String clusterName; /** - * The purpose of the id field is to be able for nodes to identify themselves beyond there + * The purpose of the id field is to be able for nodes to identify themselves beyond their * host/port. For example an application might generate a persistent id so if they rejoin the * cluster at a different host and port we are aware it is the same node. */ @@ -43,15 +43,13 @@ public abstract class GossipMember implements Comparable<GossipMember> { /** * Constructor. - * - * @param host - * The hostname or IP address. - * @param port - * The port number. + * + * @param uri + * A URI object containing IP/hostname and port * @param heartbeat - * The current heartbeat. + * The current heartbeat * @param id - * an id that may be replaced after contact + * An id that may be replaced after contact */ public GossipMember(String clusterName, URI uri, String id, long heartbeat) { this.clusterName = clusterName; http://git-wip-us.apache.org/repos/asf/incubator-gossip/blob/4e13c899/src/main/java/org/apache/gossip/RemoteGossipMember.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/gossip/RemoteGossipMember.java b/src/main/java/org/apache/gossip/RemoteGossipMember.java index 88c568a..a9e6a76 100644 --- a/src/main/java/org/apache/gossip/RemoteGossipMember.java +++ b/src/main/java/org/apache/gossip/RemoteGossipMember.java @@ -30,12 +30,10 @@ public class RemoteGossipMember extends GossipMember { /** * Constructor. * - * @param hostname - * The hostname or IP address. - * @param port - * The port number. + * @param uri + * A URI object containing IP/hostname and port * @param heartbeat - * The current heartbeat. + * The current heartbeat */ public RemoteGossipMember(String clusterName, URI uri, String id, long heartbeat) { super(clusterName, uri, id, heartbeat); http://git-wip-us.apache.org/repos/asf/incubator-gossip/blob/4e13c899/src/main/java/org/apache/gossip/StartupSettings.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/gossip/StartupSettings.java b/src/main/java/org/apache/gossip/StartupSettings.java index 9475536..93757bd 100644 --- a/src/main/java/org/apache/gossip/StartupSettings.java +++ b/src/main/java/org/apache/gossip/StartupSettings.java @@ -58,8 +58,8 @@ public class StartupSettings { * * @param id * The id to be used for this service - * @param port - * The port to start the service on. + * @param uri + * A URI object containing IP/hostname and port * @param logLevel * unused */ @@ -80,8 +80,8 @@ public class StartupSettings { * * @param id * The id to be used for this service - * @param port - * The port to start the service on. + * @param uri + * A URI object containing IP/hostname and port */ public StartupSettings(String id, URI uri, GossipSettings gossipSettings, String cluster) { this.id = id;
