matrei commented on code in PR #14093:
URL: https://github.com/apache/grails-core/pull/14093#discussion_r2021028091


##########
grails-test-suite-uber/build.gradle:
##########
@@ -1,39 +1,60 @@
-configurations.testCompileClasspath {
-    exclude module: 'grails-plugin-testing'
+plugins {
+    id 'groovy'
+    id 'project-report'
 }
 
-dependencies {
-
-    api project(':grails-test-suite-base'),
-        project(':grails-plugin-interceptors'),
-        project(':grails-plugin-controllers')
-
-    api "org.apache.tomcat:tomcat-jdbc"
+version = projectVersion
+group = 'org.grails'
 
-    testRuntimeOnly "com.h2database:h2"
-    testRuntimeOnly "org.springframework:spring-aspects"
-    testRuntimeOnly "org.aspectj:aspectjrt", "org.aspectj:aspectjweaver"
-
-    testImplementation project(':grails-plugin-codecs'),
-                project(':grails-plugin-domain-class') ,
-                project(':grails-plugin-url-mappings') ,
-                project(":grails-plugin-datasource"),
-                project(":grails-plugin-services"),
-                project(":grails-plugin-rest"),
-                project(":grails-plugin-i18n"),
-                project(":grails-plugin-databinding"),
-                project(':grails-spring')
+dependencies {
+    implementation platform(project(':grails-bom'))
 
-    testImplementation "org.grails:grails-datastore-gorm-hibernate5"
     testImplementation project(':grails-async-plugin')
+    testImplementation project(':grails-plugin-codecs')
+    testImplementation project(':grails-plugin-controllers')
+    testImplementation project(':grails-plugin-databinding')
+    testImplementation project(':grails-plugin-datasource')
+    testImplementation project(':grails-plugin-domain-class')
+    testImplementation project(':grails-plugin-i18n')
+    testImplementation project(':grails-plugin-interceptors')
+    testImplementation project(':grails-plugin-rest')
+    testImplementation project(':grails-plugin-services')
+    testImplementation project(':grails-plugin-url-mappings')
+    testImplementation project(':grails-spring')
+    testImplementation project(':grails-test-suite-base')
+    testImplementation project(':grails-testing-support')
+    testImplementation 'org.apache.groovy:groovy'
+    testImplementation 'org.apache.groovy:groovy-test-junit5'
+    testImplementation 'org.junit.jupiter:junit-jupiter-api'
+    testImplementation 'org.grails:grails-datastore-gorm-hibernate5'
     testImplementation "org.grails.plugins:gsp"
-    testImplementation "org.grails:grails-gorm-testing-support"
-    testImplementation "org.grails:grails-web-testing-support", {
+    testImplementation 'org.grails:grails-gorm-testing-support', {
+        // This is a local project dependency
         exclude module:'grails-testing-support'
     }
-    testImplementation project(':grails-testing-support')
+    testImplementation 'org.grails:grails-web-testing-support', {
+        // This is a local project dependency
+        exclude module:'grails-testing-support'
+    }
+    testImplementation 'org.objenesis:objenesis'
 
-    testImplementation "com.fasterxml.jackson.core:jackson-databind"
+    testCompileOnly 'jakarta.servlet:jakarta.servlet-api'
+    testCompileOnly 'org.springframework:spring-test', {
+        // MockHttpServletRequest/Response/Context used in many classes
+    }
+
+    testRuntimeOnly 'com.h2database:h2'
+    testRuntimeOnly 'org.apache.tomcat:tomcat-jdbc'
+    testRuntimeOnly 'org.aspectj:aspectjrt'
+    testRuntimeOnly 'org.aspectj:aspectjweaver'
+    testRuntimeOnly 'org.junit.jupiter:junit-jupiter-engine'
+    testRuntimeOnly 'org.springframework:spring-aspects'
+
+
+    // Testing
+    testImplementation('org.spockframework:spock-core') { transitive = false }

Review Comment:
   No, see previous response



##########
grails-web-mvc/build.gradle:
##########
@@ -1,4 +1,50 @@
+plugins {
+    id 'groovy'
+    id 'java-library'
+    id 'project-report'
+}
+
+version = projectVersion
+group = 'org.grails'
+
 dependencies {
+
+    implementation platform(project(':grails-bom'))
+
     api project(":grails-web-common"),

Review Comment:
   See previous response



##########
grails-web-url-mappings/build.gradle:
##########
@@ -1,7 +1,20 @@
+plugins {
+    id 'groovy'
+    id 'java-library'
+    id 'project-report'
+}
+
+version = projectVersion
+group = 'org.grails'
+
 dependencies {
+
+    implementation platform(project(':grails-bom'))
+
     api project(":grails-web-common")

Review Comment:
   See previous response



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to