jdaugherty commented on code in PR #14092:
URL: https://github.com/apache/grails-core/pull/14092#discussion_r2019975472
##########
grails-web-url-mappings/src/main/groovy/grails/web/mapping/ResponseRedirector.groovy:
##########
@@ -39,6 +39,7 @@ class ResponseRedirector {
public static final String ARGUMENT_PERMANENT = "permanent"
public static final String ARGUMENT_ABSOLUTE = "absolute"
+ public static final String ARGUMENT_MOVED = "moved" // Renamed from
ARGUMENT_TEMPORARY
Review Comment:
can you remove the comment?
##########
grails-web-url-mappings/src/main/groovy/grails/web/mapping/ResponseRedirector.groovy:
##########
@@ -110,37 +111,32 @@ class ResponseRedirector {
/*
* Redirects the response the the given URI
*/
- private void redirectResponse(String serverBaseURL, String actualUri,
HttpServletRequest request, HttpServletResponse response, boolean permanent,
boolean absolute) {
- if(log.isDebugEnabled()) {
Review Comment:
There appear to be far more changes to the original code than I expected on
this subsequent change.
Some examples:
* not calling the link generator / change of hte uri
* removal of logging
* header changes
Can you explain why you rewrote this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
