jdaugherty commented on code in PR #14133:
URL: https://github.com/apache/grails-core/pull/14133#discussion_r2043136317
##########
grails-bootstrap/build.gradle:
##########
@@ -12,18 +12,17 @@ group = 'org.apache.grails.bootstrap'
dependencies {
implementation platform(project(':grails-bom'))
- // compile grails-bootstap with the Groovy version provided by Gradle
- // to ensure build compatibility with Gradle, currently Groovy 3.0.x
- // when used by grails-gradle-plugin
- // see: https://docs.gradle.org/current/userguide/compatibility.html#groovy
implementation "org.springframework:spring-context"
implementation "org.springframework.boot:spring-boot-autoconfigure"
+ api 'org.apache.grails.gradle:grails-gradle-model', {
+ exclude group: 'org.codehaus.groovy'
+ }
- compileOnly "org.codehaus.groovy:groovy:$GroovySystem.version"
- compileOnly "org.codehaus.groovy:groovy-templates:$GroovySystem.version"
- compileOnly "org.codehaus.groovy:groovy-xml:$GroovySystem.version"
- compileOnly "org.codehaus.groovy:groovy-ant:$GroovySystem.version"
+ compileOnly "org.apache.groovy:groovy"
Review Comment:
A couple thoughts:
1. The gradle plugin no longer uses bootstrap - I've pulled that code into
the model. Otherwise we would have a circular dependency.
2. I think you're right on shell though. We'll need to compile with groovy
3 only because of Grails shell.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
