jdaugherty commented on code in PR #29:
URL: https://github.com/apache/grails-profiles/pull/29#discussion_r2051320748
##########
base/skeleton/build.gradle:
##########
@@ -4,7 +4,7 @@ buildscript {
mavenCentral()
}
dependencies {
- classpath platform("org.grails:grails-bom:$grailsVersion")
+ classpath platform("org.apache.grails:grails-bom:$grailsVersion")
Review Comment:
this should be grails-gradle-bom
##########
profile/skeleton/build.gradle:
##########
@@ -3,25 +3,27 @@ buildscript {
gradlePluginPortal()
mavenCentral()
maven { url "https://repo.grails.org/grails/core"; }
+ maven { url "https://repository.apache.org/content/groups/snapshots/"; }
// mavenLocal() // for local testing, do not commit uncommented
}
dependencies {
- classpath platform("org.grails:grails-bom:$grailsVersion")
- classpath "org.grails:grails-gradle-plugin"
+ classpath platform("org.apache.grails:grails-bom:$grailsVersion")
+ classpath "org.apache.grails:grails-gradle-plugins"
}
}
-apply plugin: "org.grails.grails-profile"
+apply plugin: "org.apache.grails.gradle.grails-profile"
-group 'org.grails.profiles'
+group 'org.apache.grails.profiles'
version '1.0.0-SNAPSHOT'
repositories {
mavenCentral()
maven { url "https://repo.grails.org/grails/core"; }
+ maven { url "https://repository.apache.org/content/groups/snapshots/"; }
// mavenLocal() // for local testing, do not commit uncommented
}
dependencies {
- profileRuntimeOnly "org.grails.profiles:base:$baseProfileVersion"
+ profileRuntimeOnly "org.apache.grails.profiles:base:$baseProfileVersion"
Review Comment:
If this is in the bom, why hard code the version?
##########
build.gradle:
##########
@@ -1,30 +1,32 @@
buildscript {
repositories {
mavenCentral()
+ maven { url "https://repository.apache.org/content/groups/snapshots/"; }
maven { url "https://repo.grails.org/grails/core"; }
// mavenLocal() // for local testing, do not commit uncommented
}
dependencies {
- classpath platform("org.grails:grails-bom:$grailsVersion")
- classpath "org.grails:grails-gradle-plugin"
+ classpath platform("org.apache.grails:grails-bom:$grailsVersion")
Review Comment:
this should be the gradle bom
##########
profile/skeleton/build.gradle:
##########
@@ -3,25 +3,27 @@ buildscript {
gradlePluginPortal()
mavenCentral()
maven { url "https://repo.grails.org/grails/core"; }
+ maven { url "https://repository.apache.org/content/groups/snapshots/"; }
// mavenLocal() // for local testing, do not commit uncommented
}
dependencies {
- classpath platform("org.grails:grails-bom:$grailsVersion")
- classpath "org.grails:grails-gradle-plugin"
+ classpath platform("org.apache.grails:grails-bom:$grailsVersion")
Review Comment:
gradle bom
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
