This is an automated email from the ASF dual-hosted git repository. jdaugherty pushed a commit to branch grails-geb in repository https://gitbox.apache.org/repos/asf/grails-core.git
commit 90d419187ddb2f64f616957421f871d899e4191a Author: James Daugherty <[email protected]> AuthorDate: Mon Apr 21 10:52:08 2025 -0400 Remove ignored tests & ignore flaky tests that fail on windows agents --- .../src/test/groovy/grails/build/logging/GrailsConsoleSpec.groovy | 2 +- .../groovy/org/grails/datastore/gorm/mongo/BasicCollectionsSpec.groovy | 1 - .../groovy/org/grails/datastore/gorm/mongo/BatchUpdateDeleteSpec.groovy | 2 -- .../test/groovy/org/grails/datastore/gorm/mongo/BigDecimalSpec.groovy | 1 - .../org/grails/datastore/gorm/mongo/EmbeddedAssociationSpec.groovy | 1 - .../groovy/org/grails/datastore/gorm/mongo/MongoEntityConfigSpec.groovy | 1 - .../groovy/org/grails/datastore/gorm/mongo/MongoGormEnhancerSpec.groovy | 1 - .../org/grails/datastore/gorm/mongo/ReadConcernArgumentSpec.groovy | 2 -- .../test/groovy/org/grails/datastore/gorm/mongo/TestSearchSpec.groovy | 2 -- .../gorm/services/multitenancy/database/DatabasePerTenantSpec.groovy | 2 -- .../src/test/groovy/org/grails/datastore/gorm/TckTestSuite.groovy | 2 ++ .../grails/plugin/formfields/FormFieldsTemplateServiceSpec.groovy | 2 +- .../test/groovy/org/grails/web/taglib/FormTagLibResourceTests.groovy | 1 - .../src/integration-test/groovy/functional/tests/TeamSpec.groovy | 1 - .../org/grails/web/mapping/LinkGeneratorWithUrlMappingsSpec.groovy | 1 - .../groovy/org/grails/web/mapping/UrlMappingsWithHttpMethodSpec.groovy | 1 - 16 files changed, 4 insertions(+), 19 deletions(-) diff --git a/grails-bootstrap/src/test/groovy/grails/build/logging/GrailsConsoleSpec.groovy b/grails-bootstrap/src/test/groovy/grails/build/logging/GrailsConsoleSpec.groovy index 688f785487..d3ec9f68b9 100644 --- a/grails-bootstrap/src/test/groovy/grails/build/logging/GrailsConsoleSpec.groovy +++ b/grails-bootstrap/src/test/groovy/grails/build/logging/GrailsConsoleSpec.groovy @@ -38,7 +38,7 @@ import java.util.regex.Pattern * @author Tom Bujok * @since 2.3 */ -@IgnoreIf({ env['CI'] || !GrailsConsole.instance.isAnsiEnabled() }) +@IgnoreIf({ !GrailsConsole.instance.isAnsiEnabled() }) class GrailsConsoleSpec extends Specification { static final String RESET = Pattern.quote(Ansi.ansi().reset().toString()) diff --git a/grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/BasicCollectionsSpec.groovy b/grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/BasicCollectionsSpec.groovy index a04ddcfc20..47bad2d4eb 100644 --- a/grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/BasicCollectionsSpec.groovy +++ b/grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/BasicCollectionsSpec.groovy @@ -55,7 +55,6 @@ class BasicCollectionsSpec extends GormDatastoreSpec{ ] } - @IgnoreIf({System.getenv('TRAVIS')}) void "Test that a map of BigDecimal works."() { when:"A payRate map is persisted" def p = new Linguist(name:"Bob") diff --git a/grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/BatchUpdateDeleteSpec.groovy b/grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/BatchUpdateDeleteSpec.groovy index cfb08a874a..d54338d722 100644 --- a/grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/BatchUpdateDeleteSpec.groovy +++ b/grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/BatchUpdateDeleteSpec.groovy @@ -31,8 +31,6 @@ class BatchUpdateDeleteSpec extends GormDatastoreSpec { Plant.count() == 4 } - // Ignore on Travis infrastructure which doesn't support MongoDB 26 - @IgnoreIf({ System.getenv("TRAVIS")}) void "Test that batch update works"() { when:"Some test data" createTestData() diff --git a/grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/BigDecimalSpec.groovy b/grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/BigDecimalSpec.groovy index 7aa6ec7f53..52da644dab 100644 --- a/grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/BigDecimalSpec.groovy +++ b/grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/BigDecimalSpec.groovy @@ -13,7 +13,6 @@ import spock.lang.IgnoreIf */ class BigDecimalSpec extends GormDatastoreSpec { - @IgnoreIf( { System.getenv('TRAVIS') } ) void "test save and retrieve big decimal value"() { when:"A big decimal is saved" def val = new BigDecimal("1.0") diff --git a/grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/EmbeddedAssociationSpec.groovy b/grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/EmbeddedAssociationSpec.groovy index 6077587d25..3911446d73 100644 --- a/grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/EmbeddedAssociationSpec.groovy +++ b/grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/EmbeddedAssociationSpec.groovy @@ -32,7 +32,6 @@ class EmbeddedAssociationSpec extends GormDatastoreSpec { i.name == "Bob" } - @IgnoreIf({System.getenv('TRAVIS')}) void "Test query with projection an embedded instance"() { given:"A domain with an embedded association" diff --git a/grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/MongoEntityConfigSpec.groovy b/grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/MongoEntityConfigSpec.groovy index 62d457fcc7..3990c600b3 100644 --- a/grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/MongoEntityConfigSpec.groovy +++ b/grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/MongoEntityConfigSpec.groovy @@ -15,7 +15,6 @@ import spock.lang.* class MongoEntityConfigSpec extends GormDatastoreSpec{ - @IgnoreIf( { System.getenv('TRAVIS_BRANCH') != null } ) def "Test custom collection config"() { given: session.mappingContext.addPersistentEntity MyMongoEntity diff --git a/grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/MongoGormEnhancerSpec.groovy b/grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/MongoGormEnhancerSpec.groovy index 39d224b4db..ba48088282 100644 --- a/grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/MongoGormEnhancerSpec.groovy +++ b/grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/MongoGormEnhancerSpec.groovy @@ -6,7 +6,6 @@ import grails.gorm.tests.GormDatastoreSpec import grails.mongodb.MongoEntity import spock.lang.* -@IgnoreIf( { System.getenv('TRAVIS_BRANCH') != null } ) class MongoGormEnhancerSpec extends GormDatastoreSpec{ def "Test is MongoEntity"() { diff --git a/grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/ReadConcernArgumentSpec.groovy b/grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/ReadConcernArgumentSpec.groovy index 0f383563df..d0c23692c8 100644 --- a/grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/ReadConcernArgumentSpec.groovy +++ b/grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/ReadConcernArgumentSpec.groovy @@ -14,8 +14,6 @@ import spock.lang.IgnoreIf /** * Created by graemerocher on 03/02/2017. */ -// These tests require MongoDB 3.4+ to run, Travis only has MongoDB 3.0 support atm -@IgnoreIf({System.getenv('TRAVIS')}) class ReadConcernArgumentSpec extends GormDatastoreSpec { @Ignore diff --git a/grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/TestSearchSpec.groovy b/grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/TestSearchSpec.groovy index 0c2babd672..531eaabbf2 100644 --- a/grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/TestSearchSpec.groovy +++ b/grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/TestSearchSpec.groovy @@ -9,8 +9,6 @@ import spock.lang.* /** * Created by graemerocher on 14/04/14. */ -// TODO: Remove IgnoreIf when travis supports MongoDB 2.6 -@IgnoreIf( { System.getenv('TRAVIS_BRANCH') != null } ) class TestSearchSpec extends GormDatastoreSpec{ void "Test simple text search"() { diff --git a/grails-datamapping-core-test/src/test/groovy/grails/gorm/services/multitenancy/database/DatabasePerTenantSpec.groovy b/grails-datamapping-core-test/src/test/groovy/grails/gorm/services/multitenancy/database/DatabasePerTenantSpec.groovy index 8469226bda..13aaba64a0 100644 --- a/grails-datamapping-core-test/src/test/groovy/grails/gorm/services/multitenancy/database/DatabasePerTenantSpec.groovy +++ b/grails-datamapping-core-test/src/test/groovy/grails/gorm/services/multitenancy/database/DatabasePerTenantSpec.groovy @@ -29,8 +29,6 @@ class DatabasePerTenantSpec extends Specification { ) @Shared IBookService bookDataService = datastore.getService(IBookService) - //Ignore test on Github Workflow because of inconsistent behavior - @IgnoreIf({ System.getenv("GITHUB_WORKFLOW")}) void 'Test database per tenant'() { when:"When there is no tenant" Book.count() diff --git a/grails-datamapping-core-test/src/test/groovy/org/grails/datastore/gorm/TckTestSuite.groovy b/grails-datamapping-core-test/src/test/groovy/org/grails/datastore/gorm/TckTestSuite.groovy index e1cfd5b4af..79d13c31f8 100644 --- a/grails-datamapping-core-test/src/test/groovy/org/grails/datastore/gorm/TckTestSuite.groovy +++ b/grails-datamapping-core-test/src/test/groovy/org/grails/datastore/gorm/TckTestSuite.groovy @@ -3,12 +3,14 @@ package org.grails.datastore.gorm import grails.gorm.tck.NotInListSpec import org.junit.platform.suite.api.SelectClasses import org.junit.platform.suite.api.Suite +import spock.lang.IgnoreIf /** * Use this class to run tck classes against the current implementation. * * @author graemerocher */ +@IgnoreIf({ os.windows }) // Fails on windows even though the NotInListSpec is in the TCK and runs @Suite @SelectClasses([NotInListSpec]) class TckTestSuite { diff --git a/grails-fields/src/test/groovy/grails/plugin/formfields/FormFieldsTemplateServiceSpec.groovy b/grails-fields/src/test/groovy/grails/plugin/formfields/FormFieldsTemplateServiceSpec.groovy index 0e8e74bb55..bbceae5d01 100644 --- a/grails-fields/src/test/groovy/grails/plugin/formfields/FormFieldsTemplateServiceSpec.groovy +++ b/grails-fields/src/test/groovy/grails/plugin/formfields/FormFieldsTemplateServiceSpec.groovy @@ -388,7 +388,7 @@ class FormFieldsTemplateServiceSpec extends BuildsAccessorFactory implements Ser // @IgnoreIf({ GrailsApplicationAttributes.metaClass.hasProperty(GrailsApplicationAttributes, "CONTROLLER_NAMESPACE_ATTRIBUTE") == false }) @IgnoreIf({ GrailsWebRequest.metaClass.respondsTo(GrailsWebRequest, "getControllerNamespace").size() == 0 }) - @Issue('https://github.com/grails-fields-plugin/grails-fields/issues/168') + @Issue('https://github.com/grails/fields/issues/168') void "resolves template from namespaced controller views directory"() { given: webRequest.setControllerNamespace('namespace') diff --git a/grails-gsp/plugin/src/test/groovy/org/grails/web/taglib/FormTagLibResourceTests.groovy b/grails-gsp/plugin/src/test/groovy/org/grails/web/taglib/FormTagLibResourceTests.groovy index 9aec12d414..bd7c9c759b 100644 --- a/grails-gsp/plugin/src/test/groovy/org/grails/web/taglib/FormTagLibResourceTests.groovy +++ b/grails-gsp/plugin/src/test/groovy/org/grails/web/taglib/FormTagLibResourceTests.groovy @@ -4,7 +4,6 @@ import grails.artefact.Artefact import grails.testing.web.UrlMappingsUnitTest import spock.lang.* -@IgnoreIf({System.getenv('CI')}) class FormTagLibResourceTests extends Specification implements UrlMappingsUnitTest<TestFormTagUrlMappings> { diff --git a/grails-test-examples/views-functional-tests/src/integration-test/groovy/functional/tests/TeamSpec.groovy b/grails-test-examples/views-functional-tests/src/integration-test/groovy/functional/tests/TeamSpec.groovy index 6bd4a135e9..052b74c490 100644 --- a/grails-test-examples/views-functional-tests/src/integration-test/groovy/functional/tests/TeamSpec.groovy +++ b/grails-test-examples/views-functional-tests/src/integration-test/groovy/functional/tests/TeamSpec.groovy @@ -82,7 +82,6 @@ class TeamSpec extends HttpClientSpec { ''') } - @IgnoreIf({ System.getenv('GITHUB_REF') }) void 'Test HAL rendering'() { when: HttpRequest request = HttpRequest.GET('/teams/hal/1') diff --git a/grails-web-url-mappings/src/test/groovy/org/grails/web/mapping/LinkGeneratorWithUrlMappingsSpec.groovy b/grails-web-url-mappings/src/test/groovy/org/grails/web/mapping/LinkGeneratorWithUrlMappingsSpec.groovy index 550726d6b3..a08afbd45a 100644 --- a/grails-web-url-mappings/src/test/groovy/org/grails/web/mapping/LinkGeneratorWithUrlMappingsSpec.groovy +++ b/grails-web-url-mappings/src/test/groovy/org/grails/web/mapping/LinkGeneratorWithUrlMappingsSpec.groovy @@ -62,7 +62,6 @@ class LinkGeneratorWithUrlMappingsSpec extends Specification{ uri == "$baseUrl/$path" } - @IgnoreIf({ env['GITHUB_WORKFLOW'] }) void "absolute links are generated when a relative link is asked for, but the deployment context is not known or set"() { when: context = null diff --git a/grails-web-url-mappings/src/test/groovy/org/grails/web/mapping/UrlMappingsWithHttpMethodSpec.groovy b/grails-web-url-mappings/src/test/groovy/org/grails/web/mapping/UrlMappingsWithHttpMethodSpec.groovy index 3e60d95bcd..918e06fa51 100644 --- a/grails-web-url-mappings/src/test/groovy/org/grails/web/mapping/UrlMappingsWithHttpMethodSpec.groovy +++ b/grails-web-url-mappings/src/test/groovy/org/grails/web/mapping/UrlMappingsWithHttpMethodSpec.groovy @@ -18,7 +18,6 @@ import spock.lang.Specification /** * @author Graeme Rocher */ -@IgnoreIf({ env['CI'] }) class UrlMappingsWithHttpMethodSpec extends Specification{ def setup() {
