jdaugherty commented on PR #14324:
URL: https://github.com/apache/grails-core/pull/14324#issuecomment-2819771173
> @jdaugherty GitHub is struggling with this PR, so I couldn't put these on
the lines
>
> **3 instances with double colon** `project('::grails-data-hibernate5')`
>
> `elApiVersion` should be 5.0.1 based on
https://projects.eclipse.org/releases/jakarta-10 and latest 5.0.x from
https://mvnrepository.com/artifact/jakarta.el/jakarta.el-api
>
> There are also a few versions set directly in build.gradle files:
>
> ```
> Targets
> Occurrences of ':[0-9]' in Project with mask '*.gradle'
> Found occurrences in Project with mask '*.gradle' (47 usages found)
> Usage in string constants (45 usages found)
> grails-gradle (1 usage found)
> grails-gradle\gradle (1 usage found)
> e2eTest.gradle (1 usage found)
> 53 e2eTestImplementation 'commons-io:commons-io:2.18.0'
> grails.core.ROOT.grails-fields (1 usage found)
> grails-fields (1 usage found)
> build.gradle (1 usage found)
> 32 testImplementation
'org.javassist:javassist:3.29.0-GA'
> grails.core.ROOT.grails-shell-cli (1 usage found)
> grails-shell-cli (1 usage found)
> build.gradle (1 usage found)
> 105 testImplementation
'com.github.jnr:jnr-posix:3.1.20'
> grails.core.ROOT.grails-test-examples-async-events-pubsub-demo (2
usages found)
> grails-test-examples\async-events-pubsub-demo (2 usages found)
> build.gradle (2 usages found)
> 51 testImplementation
'io.micronaut.serde:micronaut-serde-jackson:2.10.2'
> 52 testImplementation
'io.micronaut:micronaut-http-client:4.6.5'
> grails.core.ROOT.grails-test-examples-gsp-spring-boot (1 usage
found)
> grails-test-examples\gsp-spring-boot\app (1 usage found)
> build.gradle (1 usage found)
> 47 implementation
'org.hibernate.validator:hibernate-validator:8.0.0.Final' // validation
> ```
>
> I am now jumping into the changes in the larger group of commits.
[a58aa14...grails-geb](https://github.com/apache/grails-core/compare/a58aa145cf7cbe36f7a3a2b2665a8daf6932ab93...grails-geb)
* The e2eTest has it hard coded because it can't use a bom; no change is
needed here.
* I believe I've made the rest of these changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
