jdaugherty commented on code in PR #14671:
URL: https://github.com/apache/grails-core/pull/14671#discussion_r2059353433
##########
grails-data-neo4j/examples/grails3-neo4j-hibernate/build.gradle:
##########
@@ -80,3 +84,7 @@ webdriverBinaries {
geckodriver "$geckodriverVersion"
}
}
+
+apply {
+ from
rootProject.layout.projectDirectory.file('gradle/webjar-asset-pipeline-config.gradle')
Review Comment:
I had avoided updating neo4j since it was only partially updated. I assume
these were just mass replaces? Should we update all of these then or leave it
for now?
##########
gradle/webjar-asset-pipeline-config.gradle:
##########
Review Comment:
actually, why can't this just be in functional-test-config? Aren't we only
ever uses assets in functional tests?
##########
gradle/webjar-asset-pipeline-config.gradle:
##########
Review Comment:
Can we rename this file to some how indicate it's only for functional and /
or tests? Maybe 'test-webjar-asset-config.gradle' ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
