jdaugherty opened a new pull request, #14684: URL: https://github.com/apache/grails-core/pull/14684
This PR: 1. merges grails-wrapper & the `expanded` wrapper that contains all of the dependencies; since users use `grails-wrapper` I went with the project names `grails-wrapper` & `grails-wrapper-impl` 2. merges the profiles into the project 3. rewrites the profile gradle logic to be cacheable, lazy, & support inheritance via a 'profileRuntimeApi` scope 4. removes the existing functional tests - they need rewritten to be in gradle. We should open a bug ticket on this. We can revert 9b8fa17d when we're ready to work on this. 5. removes the groovy jmx library from shell - this was included so profiles had access, but as part of the gradle refactor, you can now include dependencies there. This may need added back to shell, but I think end projects should include the libraries they need to run the scripts they use instead of being included in the grails-shell-cli. 6. due to https://github.com/gradle/gradle/issues/2986 I did have to change the global dependency exclude, I spoke to @jamesfredley and we agreed to minimize it to '.gitignore' and '.gitkeep' 7. the shell scripts are checked in under grails-wrapper/shell are still used manually - well need to change the process that stages these scripts for the wrapper in end user projects. I believe these projects are `grails-profiles/base` and `grails-profiles/profile`. We should create a ticket for this work so that when base builds, it copies from the associated location. 8. gradlew scripts are checked in under some of the profiles, we should just copy the version grails uses to match what we expect to run with. We can take a similar approach, where we create a copy task in gradle that runs as part of build. 9. enhances the extract dependencies task to use the project property 'pomArtifactId' instead of the project name when generating the bom dependencies 10. some tests are now passing that have been previously been marked with PendingFeature and the annotation is removed 11. I have removed the external JS project specific profiles - vue, angular, react. These profiles are all extensions of the rest-api profile and this matches the forge decision to not include them. Otherwise, we would be maintaining them every time angular is upgraded. @matrei would you be willing to do 7 or 8 above in a separate PR after this is merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
