jdaugherty commented on code in PR #14683:
URL: https://github.com/apache/grails-core/pull/14683#discussion_r2069705596
##########
gradle/assemble-root-config.gradle:
##########
@@ -85,7 +85,7 @@ class GrailsCreateStartScripts extends CreateStartScripts {
generator.classpath = projectArtifacts +
getClasspath().resolvedConfiguration.resolvedArtifacts.collect { artifact ->
def dependency = artifact.moduleVersion.id
String installedFile =
"lib/$dependency.group/$dependency.name/jars/$artifact.file.name"
- if (dependency.group.startsWith('org.apache.grails') &&
!project.file(installedFile).exists()) {
+ if (dependency.group.startsWith('org.apache.grails') &&
dependency.name != 'grails-gradle-model' &&
!project.file(installedFile).exists()) {
Review Comment:
I think we should add this comment here:
// TODO: consider includedBuilds as artifacts by iterating over
gradle.includedBuilds.projectDir to find included build artifacts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
