jdaugherty commented on code in PR #22:
URL:
https://github.com/apache/grails-github-actions/pull/22#discussion_r2147368696
##########
post-release/action.yml:
##########
@@ -114,7 +114,8 @@ runs:
git checkout -b "${MERGE_BRANCH_NAME}" "${GITHUB_REF}"
echo "Setting new snapshot version"
- sed -i
"s/^projectVersion.*$/projectVersion\=${NEXT_VERSION}-SNAPSHOT/"
gradle.properties
+ sed -i
"s/^projectVersion\=.*$/projectVersion\=${NEXT_VERSION}-SNAPSHOT/"
gradle.properties
+ sed -i "s/^version\=.*$/projectVersion\=${NEXT_VERSION}-SNAPSHOT/"
gradle.properties
Review Comment:
This is a bug
##########
deploy-github-pages/entrypoint.sh:
##########
@@ -224,23 +224,36 @@ if [[ "$GRADLE_PUBLISH_RELEASE" == "false" ]]; then
else
echo "Release detected"
- versionFolder="${VERSION%.*}"
- versionFolder="${versionFolder}.x"
- echo "Version folder will be ${versionFolder}"
-
- # Publish to the version folder first
- BASE_PUBLISH_PATH="./${versionFolder}"
+ # Publish to the specific version folder
+ echo "::group::Publishing Specific Version: ${VERSION}"
+ BASE_PUBLISH_PATH="./${VERSION}"
if [ -n "${TARGET_SUBFOLDER}" ]; then
- PUBLISH_PATH="./${versionFolder}/${TARGET_SUBFOLDER}"
+ PUBLISH_PATH="./${VERSION}/${TARGET_SUBFOLDER}"
else
- PUBLISH_PATH="./${versionFolder}"
+ PUBLISH_PATH="./${VERSION}"
fi
publish_artifacts
echo "Published documentation to ${PUBLISH_PATH}"
+ echo "::endgroup::"
+
+ # Publish to the generic version folder
+ genericVersionFolder="${VERSION%.*}"
+ genericVersionFolder="${versionFolder}.x"
Review Comment:
also a bug, great catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
