matrei commented on code in PR #148: URL: https://github.com/apache/grails-quartz/pull/148#discussion_r2160286475
########## gradle/docs-config.gradle: ########## @@ -1,34 +1,104 @@ -import org.grails.gradle.plugin.doc.PublishGuideTask +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ -apply plugin: 'org.apache.grails.gradle.grails-docs' +import org.asciidoctor.gradle.jvm.AsciidoctorTask -configurations.register('groovydocConfiguration') -configurations.register('guideConfiguration') +apply plugin: 'org.asciidoctor.jvm.convert' -dependencies { - - groovydocConfiguration localGroovy(), { - because 'groovydoc needs to run with the same version as Gradle' +configurations.register('documentation') { + canBeConsumed = false + canBeResolved = true + attributes { + attribute(Category.CATEGORY_ATTRIBUTE, objects.named(Category, Category.LIBRARY)) + attribute(Bundling.BUNDLING_ATTRIBUTE, objects.named(Bundling, Bundling.EXTERNAL)) + attribute(Usage.USAGE_ATTRIBUTE, objects.named(Usage, Usage.JAVA_RUNTIME)) } - guideConfiguration 'org.apache.grails:grails-docs-core' - guideConfiguration 'org.apache.groovy:groovy-ant' - guideConfiguration 'org.apache.groovy:groovy-templates' +} + +dependencies { + documentation platform("org.apache.grails:grails-bom:$grailsVersion") + documentation 'org.apache.groovy:groovy-ant' + documentation 'org.apache.groovy:groovy-groovydoc' } tasks.withType(Groovydoc).configureEach { access = GroovydocAccess.PROTECTED processScripts = false includeMainForScripts = false - includeAuthor = true - classpath = configurations.groovydocConfiguration - groovyClasspath = configurations.groovydocConfiguration + includeAuthor = false + classpath = configurations.documentation + groovyClasspath = configurations.documentation } -tasks.withType(PublishGuideTask).configureEach { - classpath = configurations.guideConfiguration +tasks.named('asciidoctor', AsciidoctorTask) { Review Comment: @jdaugherty On the other hand, The `PublishGuideTask` and `DocPublisher` seems to need some updating and refactoring. ```console Execution failed for task ':docs'. > Could not resolve all files for configuration ':docs'. > Could not find org.grails:grails-docs:7.0.0-SNAPSHOT. Searched in the following locations: - https://repo.maven.apache.org/maven2/org/grails/grails-docs/7.0.0-SNAPSHOT/maven-metadata.xml - https://repo.maven.apache.org/maven2/org/grails/grails-docs/7.0.0-SNAPSHOT/grails-docs-7.0.0-SNAPSHOT.pom - https://repo.grails.org/grails/restricted/org/grails/grails-docs/7.0.0-SNAPSHOT/maven-metadata.xml - https://repo.grails.org/grails/restricted/org/grails/grails-docs/7.0.0-SNAPSHOT/grails-docs-7.0.0-SNAPSHOT.pom ``` I'll leave this as is for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
