matrei commented on code in PR #1143:
URL:
https://github.com/apache/grails-spring-security/pull/1143#discussion_r2219735442
##########
gradle/grails-web-app-config.gradle:
##########
Review Comment:
I don't think this is a good idea.
1. The dependencies of a default Grails app is a moving target.
2. In my opinion, projects should define the dependencies they need, in the
right scope, nothing more, nothing less.
3. Pretty much everything except the dependencies can be put in common
config files. Dependencies should be specified per project for visibility
(again, just my opinion).
##########
plugin-cas/examples/spring-security-cas-test1/build.gradle:
##########
@@ -18,36 +18,18 @@
*/
plugins {
- id 'org.apache.grails.gradle.grails-web'
id 'cloud.wondrify.asset-pipeline'
}
group = 'spring.security.cas'
+apply from:
rootProject.layout.projectDirectory.file('gradle/grails-web-app-config.gradle')
dependencies {
-
- implementation platform("org.apache.grails:grails-bom:$grailsVersion")
implementation project(':cas-plugin')
- implementation 'org.apache.grails:grails-core'
- implementation 'org.apache.grails:grails-rest-transforms'
- implementation 'org.apache.grails:grails-web-boot'
- implementation 'org.apache.grails:grails-gsp'
- // 3rd party client-side assets bundled in webjars
+ // TODO: Switch to the same version of bootstrap across all security
projects
Review Comment:
Why?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
