bkoehm commented on code in PR #1143:
URL:
https://github.com/apache/grails-spring-security/pull/1143#discussion_r2220522678
##########
plugin-oauth2/plugin/build.gradle:
##########
@@ -100,10 +100,11 @@ dependencies {
}
compileOnly 'org.apache.groovy:groovy' // Provided as this is a Grails
plugin
- integrationTestImplementation
'org.apache.grails:grails-testing-support-web'
- integrationTestImplementation 'org.spockframework:spock-core'
+ testImplementation
platform("org.apache.grails:grails-bom:$grailsVersion")
+ testImplementation 'org.apache.grails:grails-testing-support-web'
+ testImplementation 'org.spockframework:spock-core'
Review Comment:
minor cosmetic: indentation incorrect?
##########
plugin-acl/plugin/build.gradle:
##########
@@ -71,3 +72,7 @@ apply {
from
rootProject.layout.projectDirectory.file('gradle/publish-config.gradle')
from
rootProject.layout.projectDirectory.file('gradle/reproducible-config.gradle')
}
+
+grails {
+ springDependencyManagement = false
Review Comment:
This is because?
##########
plugin-core/examples/integration-test-app/src/integration-test/groovy/grails/plugin/springsecurity/GormUserDetailsServiceSpec.groovy:
##########
@@ -44,7 +45,7 @@ class GormUserDetailsServiceSpec extends
AbstractIntegrationSpec {
'authority.groupAuthorityNameField', 'userLookup.authoritiesPropertyName']
private securityConfigGroupPropertyValues
- def passwordEncoder
+ PasswordEncoder passwordEncoder
Review Comment:
minor cosmetic: indentation not correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
