jdaugherty commented on code in PR #1144:
URL:
https://github.com/apache/grails-spring-security/pull/1144#discussion_r2220570191
##########
plugin-ui/plugin/build.gradle:
##########
@@ -45,7 +45,7 @@ dependencies {
implementation 'org.apache.grails:grails-controllers'
implementation 'org.apache.grails:grails-converters'
implementation 'org.apache.grails:grails-gsp'
- implementation "org.apache.grails.views:grails-layout:$grailsVersion"
+ implementation 'org.apache.grails.views:grails-layout'
Review Comment:
We shouldn't be including internal libraries - in the M5 it's supposed to be
included via the include of GSP.Including this here will cause it to break
again on the RC1
##########
plugin-ui/examples/extended/grails-app/views/layouts/register.gsp:
##########
@@ -19,7 +19,6 @@
<!doctype html>
<html class="no-js" lang="">
<head>
- <title><g:layoutTitle/></title>
Review Comment:
Was there a race condition with the layout title? the html seemed to be the
same when i dumped it.
##########
plugin-ui/examples/simple/build.gradle:
##########
@@ -32,7 +32,7 @@ dependencies {
implementation project(':ui-plugin')
implementation 'org.apache.grails:grails-core'
implementation 'org.apache.grails:grails-gsp'
- implementation "org.apache.grails.views:grails-layout:$grailsVersion"
+ implementation 'org.apache.grails.views:grails-layout'
Review Comment:
We shouldn't be including internal libraries - in the M5 it's supposed to be
included via the include of GSP. Including this here will cause it to break
again on the RC1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
