jamesfredley commented on code in PR #389:
URL: 
https://github.com/apache/grails-static-website/pull/389#discussion_r2423204179


##########
buildSrc/src/main/groovy/org/grails/gradle/HtaccessTask.groovy:
##########


Review Comment:
   url was a leftover and unused, so removing it was correct.  
   
   The `\n`'s and `+`'s gave me a bit of PTSD, but I like the idea of having 
each entry listed on its own line.  
   
   I took all of these changes and tweaked `HT_ACCESS_CONTENT` as follows.
   
   
   ```
       private static final List<String> DOMAINS = [
               'https://*.kapa.ai/',
               'https://kapa-widget-proxy-la7dkmplpq-uc.a.run.app',
               'https://www.google.com/recaptcha/',
               'https://www.gstatic.com/recaptcha/',
               'https://hcaptcha.com',
               'https://*.hcaptcha.com'
           ]
   
       private static String HT_ACCESS_CONTENT =
               '# CSP permissions for grails.apache.org - 
https://issues.apache.org/jira/browse/INFRA-27297\n' +
               '# Ref 
https://docs.kapa.ai/integrations/understanding-csp-cors\n' +
               'SetEnv CSP_PROJECT_DOMAINS "' + DOMAINS.join(' ') + '"'
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to