This is an automated email from the ASF dual-hosted git repository. borinquenkid pushed a commit to branch 8.0.x-hibernate7 in repository https://gitbox.apache.org/repos/asf/grails-core.git
commit df0ea2f67c34c9576237dc34f377560859a89aa0 Author: Walter Duque de Estrada <[email protected]> AuthorDate: Fri Feb 27 08:41:44 2026 -0600 Fix PMD issues in HibernateConnectionSourceFactory --- grails-data-hibernate7/PMD.md | 10 +++++----- .../connections/HibernateConnectionSourceFactory.java | 11 ++++++++++- 2 files changed, 15 insertions(+), 6 deletions(-) diff --git a/grails-data-hibernate7/PMD.md b/grails-data-hibernate7/PMD.md index 113862917e..3768c8b922 100644 --- a/grails-data-hibernate7/PMD.md +++ b/grails-data-hibernate7/PMD.md @@ -85,11 +85,11 @@ DataflowAnomalyAnalysis,org.grails.orm.hibernate.cfg.domainbinding.util.TableFor DataflowAnomalyAnalysis,org.grails.orm.hibernate.cfg.domainbinding.util.TableForManyCalculator,92,YES AvoidLiteralsInIfCondition,org.grails.orm.hibernate.cfg.domainbinding.util.UniqueNameGenerator,51,YES CloseResource,org.grails.orm.hibernate.connections.HibernateConnectionSource,53,YES -CloseResource,org.grails.orm.hibernate.connections.HibernateConnectionSourceFactory,109, -CloseResource,org.grails.orm.hibernate.connections.HibernateConnectionSourceFactory,172, -AvoidCatchingThrowable,org.grails.orm.hibernate.connections.HibernateConnectionSourceFactory,237, -CloseResource,org.grails.orm.hibernate.connections.HibernateConnectionSourceFactory,256, -DataflowAnomalyAnalysis,org.grails.orm.hibernate.connections.HibernateConnectionSourceFactory,298, +CloseResource,org.grails.orm.hibernate.connections.HibernateConnectionSourceFactory,109,YES +CloseResource,org.grails.orm.hibernate.connections.HibernateConnectionSourceFactory,172,YES +AvoidCatchingThrowable,org.grails.orm.hibernate.connections.HibernateConnectionSourceFactory,237,YES +CloseResource,org.grails.orm.hibernate.connections.HibernateConnectionSourceFactory,256,YES +DataflowAnomalyAnalysis,org.grails.orm.hibernate.connections.HibernateConnectionSourceFactory,298,YES DataflowAnomalyAnalysis,org.grails.orm.hibernate.query.JpaCriteriaQueryCreator,131, DataflowAnomalyAnalysis,org.grails.orm.hibernate.query.JpaFromProvider,62, AvoidLiteralsInIfCondition,org.grails.orm.hibernate.query.JpaFromProvider,150, diff --git a/grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/connections/HibernateConnectionSourceFactory.java b/grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/connections/HibernateConnectionSourceFactory.java index 888d4a232e..4af992756a 100644 --- a/grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/connections/HibernateConnectionSourceFactory.java +++ b/grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/connections/HibernateConnectionSourceFactory.java @@ -61,6 +61,11 @@ import org.springframework.core.io.Resource; * @author Graeme Rocher * @since 6.0 */ +@SuppressWarnings({ + "PMD.CloseResource", + "PMD.AvoidCatchingThrowable", + "PMD.DataflowAnomalyAnalysis" +}) public class HibernateConnectionSourceFactory extends AbstractConnectionSourceFactory<SessionFactory, HibernateConnectionSourceSettings> implements ApplicationContextAware, MessageSourceAware { @@ -193,7 +198,11 @@ public class HibernateConnectionSourceFactory hibernateSettings.getConfigLocations(), r -> configuration.configure(r.getURL())); applyResources( hibernateSettings.getMappingLocations(), - r -> configuration.addInputStream(r.getInputStream())); + r -> { + try (var is = r.getInputStream()) { + configuration.addInputStream(is); + } + }); applyResources( hibernateSettings.getCacheableMappingLocations(), r -> configuration.addCacheableFile(r.getFile()));
