jamesfredley opened a new pull request, #85:
URL: https://github.com/apache/grails-forge-ui/pull/85

   ## Summary
   
   - Fix incomplete `test` → `reloading` rename in `initializeState.js` from PR 
#84, which caused `form.reloading` to be `undefined` in the application state
   - Regenerate all stale snapshot files to match the corrected state
   
   ## Details
   
   PR #84 renamed the `test` concept to `reloading` across the codebase, but 
missed the state key assignment in `initializeState.js` line 16 (`test:` should 
have been `reloading:`). This caused:
   
   - `form.reloading` to always be `undefined` (the value was stored under the 
`test` key instead)
   - 8 snapshot failures in `useApplicationForm.test.jsx` (rendered 
`"undefined"` instead of `""` or the actual value)
   - 1 snapshot failure in `useAvailableFeatures.test.jsx` (stale 
`className="test"` reference)
   
   ## Changes
   
   | File | Change |
   |------|--------|
   | `app/launch/src/state/factories/initializeState.js` | `test:` → 
`reloading:` on line 16 |
   | `useApplicationForm.test.jsx.snap` | Regenerated (8 snapshots updated with 
correct reloading values) |
   | `useAvailableFeatures.test.jsx.snap` | Regenerated (`className="test"` → 
`className="reloading"`) |
   
   ## Testing
   
   All 30 tests pass, 11 snapshots regenerated:
   
   ```
   Test Suites: 5 passed, 5 total
   Tests:       30 passed, 30 total
   Snapshots:   11 written, 1 passed, 12 total
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to