This is an automated email from the ASF dual-hosted git repository. matrei pushed a commit to branch feat/http-client-form-post in repository https://gitbox.apache.org/repos/asf/grails-core.git
commit fdd11d04f09f9c3d33b9aebca0419d6c0949069a Author: Mattias Reichel <[email protected]> AuthorDate: Sun Jun 14 13:40:01 2026 +0200 test: update `DirtyCheckBindingSpec` to use `httpPostForm` --- .../groovy/gorm/DirtyCheckBindingSpec.groovy | 28 +++++++++++++++------- 1 file changed, 20 insertions(+), 8 deletions(-) diff --git a/grails-test-examples/gorm/src/integration-test/groovy/gorm/DirtyCheckBindingSpec.groovy b/grails-test-examples/gorm/src/integration-test/groovy/gorm/DirtyCheckBindingSpec.groovy index 637a1fc8be..b068c43f3a 100644 --- a/grails-test-examples/gorm/src/integration-test/groovy/gorm/DirtyCheckBindingSpec.groovy +++ b/grails-test-examples/gorm/src/integration-test/groovy/gorm/DirtyCheckBindingSpec.groovy @@ -35,12 +35,17 @@ import org.apache.grails.testing.http.client.HttpClientSupport @Tag('http-client') class DirtyCheckBindingSpec extends Specification implements HttpClientSupport { - private static final String FORM = 'application/x-www-form-urlencoded' - @Issue('https://github.com/apache/grails-core/issues/15681') void 'bindData over HTTP does not bind id or version on a domain extending a @DirtyCheck base'() { when: 'a form submission posts id, version and a regular property' - def response = httpPost('/dirtyCheckBinding/bind', 'id=99&version=5&description=Opening+balance', FORM) + def response = httpPostForm( + '/dirtyCheckBinding/bind', + [ + id: 99, + version: 5, + description: 'Opening balance' + ] + ) then: 'the request succeeds' response.assertStatus(200) @@ -56,12 +61,19 @@ class DirtyCheckBindingSpec extends Specification implements HttpClientSupport { @Issue('https://github.com/apache/grails-core/issues/15681') void 'binding only a regular property over HTTP leaves id and version null'() { when: - def response = httpPost('/dirtyCheckBinding/bind', 'description=Closing+balance', FORM) + def response = httpPostForm( + '/dirtyCheckBinding/bind', + [ + description: 'Closing balance' + ] + ) then: - response.assertStatus(200) - response.assertContains('description=Closing balance') - response.assertContains('id=null') - response.assertContains('version=null') + with(response) { + assertStatus(200) + assertContains('description=Closing balance') + assertContains('id=null') + assertContains('version=null') + } } }
