This is an automated email from the ASF dual-hosted git repository.

matrei pushed a commit to branch grails8-groovy5-sb4
in repository https://gitbox.apache.org/repos/asf/grails-core.git


The following commit(s) were added to refs/heads/grails8-groovy5-sb4 by this 
push:
     new da62b076fd test: revert changes to `GroovyChangeLogSpec`
da62b076fd is described below

commit da62b076fddc3c3a7e56809b76fb57818257551b
Author: Mattias Reichel <[email protected]>
AuthorDate: Sun Jun 14 14:25:14 2026 +0200

    test: revert changes to `GroovyChangeLogSpec`
    
    The previous change was the result of a problem with the
    TestLens GitHub CI app/addon.
    
    After this was resolved upstream, the change is no longer
    necessary.
---
 .../liquibase/GroovyChangeLogSpec.groovy              | 19 ++++---------------
 1 file changed, 4 insertions(+), 15 deletions(-)

diff --git 
a/grails-data-hibernate5/dbmigration/src/test/groovy/org/grails/plugins/databasemigration/liquibase/GroovyChangeLogSpec.groovy
 
b/grails-data-hibernate5/dbmigration/src/test/groovy/org/grails/plugins/databasemigration/liquibase/GroovyChangeLogSpec.groovy
index d794640852..0059c43fa2 100644
--- 
a/grails-data-hibernate5/dbmigration/src/test/groovy/org/grails/plugins/databasemigration/liquibase/GroovyChangeLogSpec.groovy
+++ 
b/grails-data-hibernate5/dbmigration/src/test/groovy/org/grails/plugins/databasemigration/liquibase/GroovyChangeLogSpec.groovy
@@ -56,18 +56,9 @@ databaseChangeLog = {
         when:
         command.handle(getExecutionContext(DbmUpdateCommand))
 
-        then: 'all change-set closures executed in the documented order'
-        // Per-changeset Liquibase log lines (e.g. confirmation message) are
-        // emitted via Liquibase's LogService whose default implementation
-        // depends on classpath state (Slf4jLogService vs JavaLogService) and
-        // whose level depends on the active Logback / java.util.logging
-        // config. We deliberately do not assert on captured stdout/stderr
-        // for those messages because both legs are environment-dependent
-        // (e.g. they fail intermittently in the Apache Groovy joint
-        // validation build). The change being applied is verified by
-        // calledBlocks; the confirmation message is exercised by the
-        // changelog parser populating GroovyChange.confirmationMessage.
+        then:
         calledBlocks == ['init', 'validate', 'change']
+        output.toString().contains('confirmation message')
     }
 
 
@@ -92,10 +83,8 @@ databaseChangeLog = {
         when:
         command.handle(getExecutionContext(DbmUpdateCommand))
 
-        then: 'validate-with-warn closure runs and the change applies normally'
-        // See the explanatory comment on 'updates a database with Groovy
-        // Change' above - asserting on stdout for the warn message is
-        // unreliable across SLF4J / JUL classpath permutations.
+        then:
+        output.toString().contains('warn message')
         calledBlocks == ['validate', 'change']
     }
 

Reply via email to