jamesfredley commented on code in PR #524:
URL:
https://github.com/apache/grails-static-website/pull/524#discussion_r3590437875
##########
conf/guides.yml:
##########
@@ -2190,10 +2190,11 @@ guides:
title: Help with Grails
- name: 'grails-email'
- title: 'Send Email and Spock Spring'
- subtitle: 'Learn how to send emails with AWS SES and SendGrid from a
Grails app and leverage Spock Spring integration to verify interaction.'
+ title: 'Sending Email from a Grails 8 Application (and Testing It)'
+ subtitle: 'Send mail over SMTP or through SendGrid / AWS SES, externalize
configuration, and verify send interactions with Spock Spring integration tests
— without live email.'
Review Comment:
Typography: this subtitle uses an em dash (`— without live email`). Project
style forbids em/en dashes. Please replace it, for example: `...verify send
interactions with Spock Spring integration tests, without live email.`
##########
conf/guides.yml:
##########
@@ -2190,10 +2190,11 @@ guides:
title: Help with Grails
- name: 'grails-email'
- title: 'Send Email and Spock Spring'
- subtitle: 'Learn how to send emails with AWS SES and SendGrid from a
Grails app and leverage Spock Spring integration to verify interaction.'
+ title: 'Sending Email from a Grails 8 Application (and Testing It)'
+ subtitle: 'Send mail over SMTP or through SendGrid / AWS SES, externalize
configuration, and verify send interactions with Spock Spring integration tests
— without live email.'
authors:
- 'Sergio del Amo'
+ - 'Sanjana'
Review Comment:
Please use a full display name here to match convention. The existing author
is `Sergio del Amo` (full name), so a bare first name `Sanjana` is
inconsistent. Use your full name, e.g. `- 'Sanjana <Lastname>'`.
##########
conf/guides.yml:
##########
@@ -2257,6 +2258,45 @@ guides:
test: Test
helpWithGrails:
title: Do you need help with Grails?
+ '8':
+ sourcePath: guides/grails-email/v8
+ publicationDate: '2026-07-01'
+ tags:
+ - 'email'
+ - 'smtp'
+ - 'sendgrid'
+ - 'ses'
+ - 'aws'
+ - 'spock-spring'
+ - 'integration-testing'
+ - 'mail'
+ sampleRef:
+ repo: 'grails-guides/grails-email'
+ branch: 'grails8'
+ toc:
+ introduction:
+ title: Introduction
+ requirements: What you will need
Review Comment:
This TOC entry uses the scalar form while every other entry uses the object
form with `title:`. Please make it consistent:
```yaml
requirements:
title: What you will need
```
##########
guides/grails-email/v8/guide/smtpMail.adoc:
##########
@@ -0,0 +1,17 @@
+The default provider delegates to the Grails Mail plugin:
+
+[source,groovy]
+.grails-app/services/example/SmtpEmailService.groovy
+----
+include::../snippets/grails-app/services/example/SmtpEmailService.groovy[]
+----
+
+Configure SMTP settings in `application.yml`:
+
+[source,yaml]
+.grails-app/conf/application.yml
+----
+include::../snippets/grails-app/conf/application-email.yml[]
Review Comment:
Snippet filename drift. This include points at `application-email.yml`, but
the caption on the line above says `.grails-app/conf/application.yml` and the
surrounding prose says `application.yml`, while the companion sample-app PR
(grails-guides/grails-email#1) names the file `application-development.yml`.
These must all agree, otherwise the vendored snippet does not correspond to a
real file in the sample repo and will drift or break the AsciiDoc build on
snippet sync. Please pick one filename and use it consistently in the sample
app, the vendored snippet, the listing caption, and the prose.
##########
guides/grails-email/v8/guide/gettingStarted.adoc:
##########
@@ -0,0 +1,17 @@
+Clone the repository and verify tests pass:
+
+[source,bash]
+----
+git clone -b grails8 https://github.com/grails-guides/grails-email.git
+cd grails-email/initial
+./gradlew test
+----
+
+The `initial/` project is a Grails 8 REST API starter with no mail wiring yet.
+
+To skip ahead, `cd complete` and run the same commands — that tree contains
the finished mail services, controller, and integration spec.
+
+[[cloneAndRun]]
+== Verify CI
Review Comment:
Chapter titles are supplied by the guide TOC in `guides.yml`. Injecting a
`== Verify CI` level-2 heading mid-chapter creates an unexpected or duplicate
section level in the rendered guide. Please make this normal prose, or demote
it to a `===` subsection if a subsection is intended.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
