jamesfredley commented on code in PR #524: URL: https://github.com/apache/grails-static-website/pull/524#discussion_r3639498132
########## guides/grails-email/v8/snippets/grails-app/conf/application.yml: ########## @@ -0,0 +1,27 @@ + #tag::mailConfig[] + mail: Review Comment: This vendored fragment omits the required `grails:` parent. In the companion app, `mail:` is nested under `grails:`; copying the rendered snippet as shown creates a root-level block that the Mail plugin will not read. Please include the parent key, ideally by tagging and vending the exact companion-app section. ########## guides/grails-email/v8/guide/gettingStarted.adoc: ########## @@ -0,0 +1,14 @@ +Clone the repository and verify tests pass: + +[source,bash] +---- +git clone -b grails8 https://github.com/grails-guides/grails-email.git +cd grails-email/initial +./gradlew test +---- + +The `initial/` project is a Grails 8 REST API starter with no mail wiring yet. + +To skip ahead, `cd complete` and run the same commands; that tree contains the finished mail services, controller, and integration spec. Review Comment: The preceding commands leave the reader in `grails-email/initial`, so `cd complete` fails because `complete` is a sibling directory. Please use `cd ../complete` here, or show a separate command block that starts from the repository root. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
