This is an automated email from the ASF dual-hosted git repository.

matrei pushed a commit to branch fix/binddata-null-missing-stale-data
in repository https://gitbox.apache.org/repos/asf/grails-core.git


The following commit(s) were added to 
refs/heads/fix/binddata-null-missing-stale-data by this push:
     new ecff934dbc chore: cleanup 
`DefaultASTDatabindingHelperDomainClassSpecialPropertiesSpec`
ecff934dbc is described below

commit ecff934dbc4acc6aead4241ed8f3b7a3e9165fac
Author: Mattias Reichel <[email protected]>
AuthorDate: Fri Aug 14 13:44:50 2026 +0200

    chore: cleanup `DefaultASTDatabindingHelperDomainClassSpecialPropertiesSpec`
---
 ...ngHelperDomainClassSpecialPropertiesSpec.groovy | 36 ++++++++++------------
 1 file changed, 17 insertions(+), 19 deletions(-)

diff --git 
a/grails-test-suite-web/src/test/groovy/org/grails/web/binding/DefaultASTDatabindingHelperDomainClassSpecialPropertiesSpec.groovy
 
b/grails-test-suite-web/src/test/groovy/org/grails/web/binding/DefaultASTDatabindingHelperDomainClassSpecialPropertiesSpec.groovy
index 81fb9a627c..e391279619 100644
--- 
a/grails-test-suite-web/src/test/groovy/org/grails/web/binding/DefaultASTDatabindingHelperDomainClassSpecialPropertiesSpec.groovy
+++ 
b/grails-test-suite-web/src/test/groovy/org/grails/web/binding/DefaultASTDatabindingHelperDomainClassSpecialPropertiesSpec.groovy
@@ -18,42 +18,44 @@
  */
 package org.grails.web.binding
 
+import groovy.transform.CompileStatic
+
+import spock.lang.Issue
+import spock.lang.Specification
+
 import grails.config.Settings
 import grails.gorm.dirty.checking.DirtyCheck
 import grails.persistence.Entity
 import grails.util.Holders
-import groovy.transform.CompileStatic
+import grails.web.databinding.DataBindingUtils
+import grails.web.databinding.GrailsWebDataBinder
 import org.grails.config.PropertySourcesConfig
 import org.grails.validation.ConstraintEvalUtils
-import spock.lang.Issue
-import spock.lang.Shared
-import spock.lang.Specification
 
-class DefaultASTDatabindingHelperDomainClassSpecialPropertiesSpec extends
-        Specification {
+class DefaultASTDatabindingHelperDomainClassSpecialPropertiesSpec extends 
Specification {
 
     private def originalConfig
 
     def setup() {
         ConstraintEvalUtils.clearDefaultConstraints()
         originalConfig = Holders.config
-        Holders.setConfig(new 
PropertySourcesConfig([(Settings.DATABINDING_DENY_BY_DEFAULT): true]))
-        grails.web.databinding.DataBindingUtils.clearBindingCaches()
-        grails.web.databinding.GrailsWebDataBinder.resetWarnedBindingShapes()
+        Holders.config = new 
PropertySourcesConfig([(Settings.DATABINDING_DENY_BY_DEFAULT): true])
+        DataBindingUtils.clearBindingCaches()
+        GrailsWebDataBinder.resetWarnedBindingShapes()
     }
 
     def cleanup() {
         ConstraintEvalUtils.clearDefaultConstraints()
-        Holders.setConfig(originalConfig)
-        grails.web.databinding.DataBindingUtils.clearBindingCaches()
-        grails.web.databinding.GrailsWebDataBinder.resetWarnedBindingShapes()
+        Holders.config = originalConfig
+        DataBindingUtils.clearBindingCaches()
+        GrailsWebDataBinder.resetWarnedBindingShapes()
     }
 
     @Issue('GRAILS-11173')
     void 'Test binding to special properties in a domain class'() {
         when:
-        Date now = new Date()
-        SomeDomainClass obj = new SomeDomainClass(dateCreated: now, 
lastUpdated: now)
+        def now = new Date()
+        def obj = new SomeDomainClass(dateCreated: now, lastUpdated: now)
         
         then:
         obj.dateCreated == null
@@ -141,8 +143,7 @@ class 
DefaultASTDatabindingHelperDomainClassSpecialPropertiesSpec extends
 
     void 'Test unconfigured binding remains permissive and preserves bindable 
false'() {
         given:
-        def configuredConfig = Holders.config
-        Holders.setConfig(null)
+        Holders.config = null
 
         when:
         def obj = new DomainWithSecureBindableDefault(name: 'Grace', title: 
'Admiral', role: 'Admin')
@@ -151,9 +152,6 @@ class 
DefaultASTDatabindingHelperDomainClassSpecialPropertiesSpec extends
         obj.name == 'Grace'
         obj.title == 'Admiral'
         obj.role == null
-
-        cleanup:
-        Holders.setConfig(configuredConfig)
     }
 
     @Issue('https://github.com/apache/grails-core/issues/15795')

Reply via email to