This is an automated email from the ASF dual-hosted git repository. borinquenkid pushed a commit to branch test/document-datamapping-core-services in repository https://gitbox.apache.org/repos/asf/grails-core.git
commit 0ed46a35e94b4b3775dbb0630660e724863a3474 Author: Walter Duque de Estrada <[email protected]> AuthorDate: Sat Aug 15 19:29:07 2026 -0500 Remove unused newMethodNode parameter from bindParametersAndSave The parameter became dead after the earlier error-reporting fix (which now uses abstractMethodNode instead of the buggy newMethodNode-based lookup). No subclass overrides this method and it has only two call sites, both updated. Unlike the getDetachedCriteriaType/lookupById warnings, this parameter has no polymorphic purpose, so it's removed rather than suppressed. Co-Authored-By: Claude Sonnet 5 <[email protected]> --- .../datastore/gorm/services/implementers/AbstractSaveImplementer.groovy | 2 +- .../grails/datastore/gorm/services/implementers/SaveImplementer.groovy | 2 +- .../datastore/gorm/services/implementers/UpdateOneImplementer.groovy | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/grails-datamapping-core/src/main/groovy/org/grails/datastore/gorm/services/implementers/AbstractSaveImplementer.groovy b/grails-datamapping-core/src/main/groovy/org/grails/datastore/gorm/services/implementers/AbstractSaveImplementer.groovy index e53bdaea9c..73b8f21c62 100644 --- a/grails-datamapping-core/src/main/groovy/org/grails/datastore/gorm/services/implementers/AbstractSaveImplementer.groovy +++ b/grails-datamapping-core/src/main/groovy/org/grails/datastore/gorm/services/implementers/AbstractSaveImplementer.groovy @@ -51,7 +51,7 @@ import static org.grails.datastore.gorm.transform.AstMethodDispatchUtils.namedAr @CompileStatic abstract class AbstractSaveImplementer extends AbstractWriteOperationImplementer { - protected Statement bindParametersAndSave(ClassNode domainClassNode, MethodNode abstractMethodNode, MethodNode newMethodNode, Parameter[] parameters, BlockStatement body, VariableExpression entityVar) { + protected Statement bindParametersAndSave(ClassNode domainClassNode, MethodNode abstractMethodNode, Parameter[] parameters, BlockStatement body, VariableExpression entityVar) { Expression argsExpression = null for (Parameter parameter in parameters) { diff --git a/grails-datamapping-core/src/main/groovy/org/grails/datastore/gorm/services/implementers/SaveImplementer.groovy b/grails-datamapping-core/src/main/groovy/org/grails/datastore/gorm/services/implementers/SaveImplementer.groovy index fa35663723..5bc6709f53 100644 --- a/grails-datamapping-core/src/main/groovy/org/grails/datastore/gorm/services/implementers/SaveImplementer.groovy +++ b/grails-datamapping-core/src/main/groovy/org/grails/datastore/gorm/services/implementers/SaveImplementer.groovy @@ -84,7 +84,7 @@ class SaveImplementer extends AbstractSaveImplementer implements SingleResultSer declS(entityVar, ctorX(domainClassNode)) ) body.addStatement( - bindParametersAndSave(domainClassNode, abstractMethodNode, newMethodNode, parameters, body, entityVar) + bindParametersAndSave(domainClassNode, abstractMethodNode, parameters, body, entityVar) ) } diff --git a/grails-datamapping-core/src/main/groovy/org/grails/datastore/gorm/services/implementers/UpdateOneImplementer.groovy b/grails-datamapping-core/src/main/groovy/org/grails/datastore/gorm/services/implementers/UpdateOneImplementer.groovy index c5a563332d..4710a80501 100644 --- a/grails-datamapping-core/src/main/groovy/org/grails/datastore/gorm/services/implementers/UpdateOneImplementer.groovy +++ b/grails-datamapping-core/src/main/groovy/org/grails/datastore/gorm/services/implementers/UpdateOneImplementer.groovy @@ -90,7 +90,7 @@ class UpdateOneImplementer extends AbstractSaveImplementer implements SingleResu declS(entityVar, lookupCall) ) BlockStatement ifBody = block() - Statement saveStmt = bindParametersAndSave(domainClassNode, abstractMethodNode, newMethodNode, parameters[1..-1] as Parameter[], ifBody, entityVar) + Statement saveStmt = bindParametersAndSave(domainClassNode, abstractMethodNode, parameters[1..-1] as Parameter[], ifBody, entityVar) ifBody.addStatement(saveStmt) body.addStatement( ifS(notNullX(entityVar),
