acezen commented on code in PR #453:
URL: https://github.com/apache/incubator-graphar/pull/453#discussion_r1566728495


##########
.github/workflows/spark.yaml:
##########
@@ -52,38 +52,44 @@ jobs:
             spark-hadoop: "spark-3.3.4-bin-hadoop3"
 
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
       with:
           submodules: true
 
     - name: Code Format Check
+      working-directory: spark
       run: |
         export JAVA_HOME=${JAVA_HOME_11_X64}
-        pushd spark
         mvn --no-transfer-progress spotless:check
-        popd
 
     - name: Build GraphAr Spark
+      working-directory: spark
       run: |
         export JAVA_HOME=${JAVA_HOME_11_X64}
-        pushd spark
         echo "Build ${{ matrix.mvn-profile }}"
-        mvn --no-transfer-progress clean package -DskipTests 
-Dspotless.check.skip=true -P ${{ matrix.mvn-profile }}
-        popd
+        mvn clean package -DskipTests -Dspotless.check.skip=true -P ${{ 
matrix.mvn-profile }}
+    
+    - name: Build Spark Docs
+      working-directory: spark
+      run: |
+        export JAVA_HOME=${JAVA_HOME_11_X64}
+        echo "Build ${{ matrix.mvn-profile }}"
+        # FIXME: the install is not necessary, but it is a workaround for the 
issue
+        mvn install -DskipTests -Dspotless.check.skip=true
+        mvn scala:doc
 
     - name: Run test
+      working-directory: spark
       run: |
         export JAVA_HOME=${JAVA_HOME_11_X64}
         export SPARK_TESTING=1
-        pushd spark
         echo "Test ${{ matrix.mvn-profile }}"
-        mvn --no-transfer-progress test -Dspotless.check.skip=true -P ${{ 
matrix.mvn-profile }}
-        popd
+        mvn test -Dspotless.check.skip=true -P ${{ matrix.mvn-profile }}

Review Comment:
   added back.



##########
.github/workflows/spark.yaml:
##########
@@ -52,38 +52,44 @@ jobs:
             spark-hadoop: "spark-3.3.4-bin-hadoop3"
 
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
       with:
           submodules: true
 
     - name: Code Format Check
+      working-directory: spark
       run: |
         export JAVA_HOME=${JAVA_HOME_11_X64}
-        pushd spark
         mvn --no-transfer-progress spotless:check
-        popd
 
     - name: Build GraphAr Spark
+      working-directory: spark
       run: |
         export JAVA_HOME=${JAVA_HOME_11_X64}
-        pushd spark
         echo "Build ${{ matrix.mvn-profile }}"
-        mvn --no-transfer-progress clean package -DskipTests 
-Dspotless.check.skip=true -P ${{ matrix.mvn-profile }}
-        popd
+        mvn clean package -DskipTests -Dspotless.check.skip=true -P ${{ 
matrix.mvn-profile }}
+    
+    - name: Build Spark Docs
+      working-directory: spark
+      run: |
+        export JAVA_HOME=${JAVA_HOME_11_X64}
+        echo "Build ${{ matrix.mvn-profile }}"
+        # FIXME: the install is not necessary, but it is a workaround for the 
issue
+        mvn install -DskipTests -Dspotless.check.skip=true

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to