acezen commented on PR #474: URL: https://github.com/apache/incubator-graphar/pull/474#issuecomment-2098942256
> For module in root pom, I consider it should be module name, rather than directory name. > > A better solution is unifying the directory name and module names. > > https://github.com/apache/incubator-graphar/blob/b33c1f0f36246fa45761fb5d122f869d18432a7e/pom.xml#L33 > > https://github.com/apache/incubator-graphar/blob/b33c1f0f36246fa45761fb5d122f869d18432a7e/spark/pom.xml#L34 > > https://github.com/apache/incubator-graphar/blob/b33c1f0f36246fa45761fb5d122f869d18432a7e/java/pom.xml#L35 Make sense to me, I will update it to the directory name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
