lixueclaire commented on issue #473: URL: https://github.com/apache/incubator-graphar/issues/473#issuecomment-2122040466
> Hello, I have a question. In the case where we have code in the `graphar` namespace but not in any nested namespace (like the `Status` class functions), should we still modify the namespace to use the C++17 nested namespace syntax? From my understanding, using the new syntax wouldn't reduce the nesting in this case. Could you please clarify this? Thank you. > > [here](https://github.com/apache/incubator-graphar/blob/87d5eeb6a7f86574328da26f08d950e3c5bc3de8/cpp/include/graphar/util/status.h#L64) Hi, I think you could separate the code and re-org them using the new style, like: ``` namespace graphar::util { ... } namespace graphar { ... } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
