acezen commented on code in PR #489:
URL: https://github.com/apache/incubator-graphar/pull/489#discussion_r1610886877
##########
cpp/include/graphar/util/reader_util.h:
##########
@@ -25,10 +25,7 @@
#include <vector>
#include "graphar/fwd.h"
-
-namespace graphar {
-
-namespace util {
+namespace graphar::util {
Review Comment:
here should have an empty line between header include and the implementation
code.
##########
cpp/include/graphar/writer/edges_builder.h:
##########
@@ -35,9 +35,7 @@
namespace arrow {
class Array;
}
-
-namespace graphar {
-namespace builder {
+namespace graphar::builder {
Review Comment:
add an empty line before namespace for code clarity
##########
cpp/src/filesystem.cc:
##########
@@ -79,7 +76,9 @@ static Status CastToLargeOffsetArray(
GAR_RETURN_ON_ARROW_ERROR_AND_ASSIGN(out, arrow::ChunkedArray::Make(chunks));
return Status::OK();
}
-} // namespace detail
+} // namespace graphar::detail
Review Comment:
Add empty line here for code clarify
##########
cpp/include/graphar/util/status.h:
##########
@@ -60,10 +60,7 @@
::graphar::Status __s = ::graphar::internal::GenericToStatus(status); \
GAR_RAISE_ERROR_IF_(!__s.ok(), __s, GAR_STRINGIFY(status)); \
} while (false)
-
-namespace graphar {
-
-namespace util {
+namespace graphar::util {
Review Comment:
add an empty line before namespace for code clarity
##########
cpp/src/filesystem.cc:
##########
@@ -30,10 +30,7 @@
#include "graphar/fwd.h"
#include "graphar/util/expression.h"
#include "graphar/util/filesystem.h"
-
-namespace graphar {
-namespace ds = arrow::dataset;
-namespace detail {
+namespace graphar::detail {
Review Comment:
here need empty line between header include and implementation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
