SemyonSinchenko commented on code in PR #512:
URL: https://github.com/apache/incubator-graphar/pull/512#discussion_r1625812703
##########
cpp/README.md:
##########
@@ -88,21 +88,27 @@ Debug build with unit tests:
$ cd build-debug
$ cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTS=ON ..
$ make -j8 # if you have 8 CPU cores, otherwise adjust, use
-j`nproc` for all cores
- $ make test # to run the tests
+```
+
+After building, you can run the unit tests with:
+
+```bash
+ $ git clone https://github.com/apache/incubator-graphar-testing.git
testing # download the testing data
+ $ GAR_TEST_DATA=${PWD}/testing ctest
Review Comment:
I would recommend to create a folder `dev/` and provide bash/python scripts
for downloading the data and set up all the variables. Like
`download_test_data.sh`, etc. We can do it in a separate PR. It is done like
this in [spark](https://github.com/apache/spark/tree/master/dev) and I found it
very user-friendly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
